Skip to content

Commit 1258970

Browse files
raulcdthisisnic
authored andcommitted
apacheGH-49493: [C++][Python] Add OpenTelemetry to our CMakePresets when bulding python-maximal (apache#49494)
### Rationale for this change OpenTelemetry can be enabled when building Python. It is currently missing from the `CMakePresets.json` ### What changes are included in this PR? Add a `features-opentelemetry` which is added as part of `features-python-maximal`. This one is used for `ninja-debug-maximal` or other maximal features. ### Are these changes tested? I tested locally with `ninja-debug-maximal` and validated that OpenTelemetry was enabled. I don't think we test our presets on CI (at least I haven't been able to find any `--preset ` presence) ### Are there any user-facing changes? If a user is building using presets, now OpenTelemetry will be built, as expected. * GitHub Issue: apache#49493 Authored-by: Raúl Cumplido <raulcumplido@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
1 parent 66a7f74 commit 1258970

1 file changed

Lines changed: 9 additions & 0 deletions

File tree

cpp/CMakePresets.json

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -131,6 +131,14 @@
131131
"ARROW_GANDIVA": "ON"
132132
}
133133
},
134+
{
135+
"name": "features-opentelemetry",
136+
"inherits": "features-basic",
137+
"hidden": true,
138+
"cacheVariables": {
139+
"ARROW_WITH_OPENTELEMETRY": "ON"
140+
}
141+
},
134142
{
135143
"name": "features-python-minimal",
136144
"inherits": [
@@ -162,6 +170,7 @@
162170
"features-filesystems",
163171
"features-flight-sql",
164172
"features-gandiva",
173+
"features-opentelemetry",
165174
"features-python"
166175
],
167176
"hidden": true,

0 commit comments

Comments
 (0)