register_variable_attribute: type mismatch for valid_range

[uramirez8707]

When registering the valid range attribute for "u_ref", the code crashed because there is a type mismatch for valid_range.

The attribute type obtained from "get_attribute_type" is a 5 (float), and the variable type obtained from "get_attribute_type" is a 6 (double).

axtype = get_attribute_type(fileobj%ncid, varid, attribute_name) xtype = get_variable_type(fileobj%ncid, varid) if (axtype .ne. xtype) then call error("type mismatch for valid_range.") endif

traceback:
fms_lad2_xanadu.x 00000000023C5A08 mpp_mod_mp_mpp_er 69 mpp_util_mpi.inc
fms_lad2_xanadu.x 0000000002520520 fms_io_utils_mod_ 144 fms_io_utils.F90
fms_lad2_xanadu.x 00000000026CDA51 netcdf_io_mod_mp_ 153 register_variable_attribute.inc
fms_lad2_xanadu.x 0000000001D6CC95 diag_output_mod_m 969 diag_output.F90
fms_lad2_xanadu.x 0000000000E49151 diag_util_mod_mp_ 2185 diag_util.F90
fms_lad2_xanadu.x 0000000000E5D12B diag_util_mod_mp_ 2633 diag_util.F90
fms_lad2_xanadu.x 0000000000E54D8C diag_util_mod_mp_ 2529 diag_util.F90
fms_lad2_xanadu.x 00000000023490EE diag_manager_mod_ 3511 diag_manager.F90
fms_lad2_xanadu.x 0000000002222745 diag_manager_mod_ 2008 diag_manager.F90
fms_lad2_xanadu.x 0000000002212B9A diag_manager_mod_ 1550 diag_manager.F90
fms_lad2_xanadu.x 00000000008BB07B land_tile_diag_mo 1069 land_tile_diag.F90
fms_lad2_xanadu.x 00000000008B0D6F land_tile_diag_mo 916 land_tile_diag.F90
fms_lad2_xanadu.x 00000000007CCE6C land_model_mod_mp 1184 land_model.F90
fms_lad2_xanadu.x 000000000040D556 MAIN__ 890 coupler_main.F90

[uramirez8707]

To fix it:
in function "write_field_meta_data" on diag_output.F90. Use ipack to check if the valid range should if a double or float. if ipack is 1 it is a double, if ipack is 2 it is a float.

replace L160 of diag_output.F90 with

select case (ipack)
     case (1)
          call register_variable_attribute(fileob,name,"valid_range", real(RANGE,8))
     case (2)
          call register_variable_attribute(fileob,name,"valid_range", real(RANGE,4))
     case default
          CALL error_mesg('diag_output_mod::write_field_meta_data',&
            &"Pack values must be 1 or 2. Contact the developers.", FATAL)
end select

[thomas-robinson]

@uramirez8707 I think it makes more sense to move the use_range if statement into the other case branch:

  ! ipack Valid values:
  !        1 = 64bit </LI>
  !        2 = 32bit </LI>
  !        4 = 16bit </LI>
  !        8 =  8bit </LI>
     select case (ipack)
     case (1)
          call register_field(fileob,name,"double",axis_names)
          IF ( Field%miss_present ) THEN
               call register_variable_attribute(fileob,name,"_FillValue",real(Field%miss_pack,8))
               call register_variable_attribute(fileob,name,"missing_value",real(Field%miss_pack,8))
          ELSE
               call register_variable_attribute(fileob,name,"_FillValue",real(CMOR_MISSING_VALUE,8))
               call register_variable_attribute(fileob,name,"missing_value",real(CMOR_MISSING_VALUE,8))
          ENDIF
         IF ( use_range ) then
              call register_variable_attribute(fileob,name,"valid_range", real(RANGE,8))
         ENDIF
     case (2) !default
          call register_field(fileob,name,"float",axis_names)
          IF ( Field%miss_present ) THEN
               call register_variable_attribute(fileob,name,"_FillValue",real(Field%miss_pack,4))
               call register_variable_attribute(fileob,name,"missing_value",real(Field%miss_pack,4))
          ELSE
               call register_variable_attribute(fileob,name,"_FillValue",real(CMOR_MISSING_VALUE,4))
               call register_variable_attribute(fileob,name,"missing_value",real(CMOR_MISSING_VALUE,4))
          ENDIF
          IF ( use_range ) then
              call register_variable_attribute(fileob,name,"valid_range", real(RANGE,4))
          ENDIF
     case default
          CALL error_mesg('diag_output_mod::write_field_meta_data',&
               &"Pack values must be 1 or 2. Contact the developers.", FATAL)
     end select