@@ -22,7 +22,6 @@ protected function setUp(): void
22
22
23
23
public function testGetAllUsersForTemplateWithDefaultParameters (): void
24
24
{
25
- // Arrange
26
25
$ userIds = [1 , 2 , 3 ];
27
26
28
27
$ this ->userMock
@@ -51,10 +50,8 @@ public function testGetAllUsersForTemplateWithDefaultParameters(): void
51
50
->method ('getLogin ' )
52
51
->willReturnOnConsecutiveCalls ('user1 ' , 'user2 ' , 'user3 ' );
53
52
54
- // Act
55
53
$ result = $ this ->userHelper ->getAllUsersForTemplate ();
56
54
57
- // Assert
58
55
$ expected = [
59
56
['id ' => 1 , 'selected ' => true , 'displayName ' => 'User One ' , 'login ' => 'user1 ' ],
60
57
['id ' => 2 , 'selected ' => false , 'displayName ' => 'User Two ' , 'login ' => 'user2 ' ],
@@ -66,7 +63,6 @@ public function testGetAllUsersForTemplateWithDefaultParameters(): void
66
63
67
64
public function testGetAllUsersForTemplateWithSelectedUser (): void
68
65
{
69
- // Arrange
70
66
$ userIds = [1 , 2 , 3 ];
71
67
$ selectedId = 2 ;
72
68
@@ -90,18 +86,15 @@ public function testGetAllUsersForTemplateWithSelectedUser(): void
90
86
->method ('getLogin ' )
91
87
->willReturnOnConsecutiveCalls ('user1 ' , 'user2 ' , 'user3 ' );
92
88
93
- // Act
94
89
$ result = $ this ->userHelper ->getAllUsersForTemplate ($ selectedId );
95
90
96
- // Assert
97
- $ this ->assertTrue ($ result [1 ]['selected ' ]); // User 2 should be selected
98
- $ this ->assertFalse ($ result [0 ]['selected ' ]); // User 1 should not be selected
99
- $ this ->assertFalse ($ result [2 ]['selected ' ]); // User 3 should not be selected
91
+ $ this ->assertTrue ($ result [1 ]['selected ' ]);
92
+ $ this ->assertFalse ($ result [0 ]['selected ' ]);
93
+ $ this ->assertFalse ($ result [2 ]['selected ' ]);
100
94
}
101
95
102
96
public function testGetAllUsersForTemplateWithAllowBlockedUsers (): void
103
97
{
104
- // Arrange
105
98
$ userIds = [1 , 2 ];
106
99
107
100
$ this ->userMock
@@ -124,17 +117,14 @@ public function testGetAllUsersForTemplateWithAllowBlockedUsers(): void
124
117
->method ('getLogin ' )
125
118
->willReturnOnConsecutiveCalls ('active ' , 'blocked ' );
126
119
127
- // Act
128
120
$ result = $ this ->userHelper ->getAllUsersForTemplate (1 , true );
129
121
130
- // Assert
131
122
$ this ->assertCount (2 , $ result );
132
123
}
133
124
134
125
public function testGetAllUsersForTemplateSkipsInvalidUserId (): void
135
126
{
136
- // Arrange
137
- $ userIds = [1 , -1 , 2 ]; // -1 should be skipped
127
+ $ userIds = [1 , -1 , 2 ];
138
128
139
129
$ this ->userMock
140
130
->expects ($ this ->once ())
@@ -160,27 +150,22 @@ public function testGetAllUsersForTemplateSkipsInvalidUserId(): void
160
150
->method ('getLogin ' )
161
151
->willReturnOnConsecutiveCalls ('user1 ' , 'user2 ' );
162
152
163
- // Act
164
153
$ result = $ this ->userHelper ->getAllUsersForTemplate ();
165
154
166
- // Assert
167
155
$ this ->assertCount (2 , $ result );
168
156
$ this ->assertEquals (1 , $ result [0 ]['id ' ]);
169
157
$ this ->assertEquals (2 , $ result [1 ]['id ' ]);
170
158
}
171
159
172
160
public function testGetAllUsersForTemplateWithEmptyUserList (): void
173
161
{
174
- // Arrange
175
162
$ this ->userMock
176
163
->expects ($ this ->once ())
177
164
->method ('getAllUsers ' )
178
165
->willReturn ([]);
179
166
180
- // Act
181
167
$ result = $ this ->userHelper ->getAllUsersForTemplate ();
182
168
183
- // Assert
184
169
$ this ->assertEmpty ($ result );
185
170
}
186
171
}
0 commit comments