Skip to content

Commit ba2a85b

Browse files
committed
refactor: removed comments
1 parent d1d1bff commit ba2a85b

File tree

1 file changed

+4
-19
lines changed

1 file changed

+4
-19
lines changed

tests/phpMyFAQ/Helper/UserHelperTest.php

Lines changed: 4 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ protected function setUp(): void
2222

2323
public function testGetAllUsersForTemplateWithDefaultParameters(): void
2424
{
25-
// Arrange
2625
$userIds = [1, 2, 3];
2726

2827
$this->userMock
@@ -51,10 +50,8 @@ public function testGetAllUsersForTemplateWithDefaultParameters(): void
5150
->method('getLogin')
5251
->willReturnOnConsecutiveCalls('user1', 'user2', 'user3');
5352

54-
// Act
5553
$result = $this->userHelper->getAllUsersForTemplate();
5654

57-
// Assert
5855
$expected = [
5956
['id' => 1, 'selected' => true, 'displayName' => 'User One', 'login' => 'user1'],
6057
['id' => 2, 'selected' => false, 'displayName' => 'User Two', 'login' => 'user2'],
@@ -66,7 +63,6 @@ public function testGetAllUsersForTemplateWithDefaultParameters(): void
6663

6764
public function testGetAllUsersForTemplateWithSelectedUser(): void
6865
{
69-
// Arrange
7066
$userIds = [1, 2, 3];
7167
$selectedId = 2;
7268

@@ -90,18 +86,15 @@ public function testGetAllUsersForTemplateWithSelectedUser(): void
9086
->method('getLogin')
9187
->willReturnOnConsecutiveCalls('user1', 'user2', 'user3');
9288

93-
// Act
9489
$result = $this->userHelper->getAllUsersForTemplate($selectedId);
9590

96-
// Assert
97-
$this->assertTrue($result[1]['selected']); // User 2 should be selected
98-
$this->assertFalse($result[0]['selected']); // User 1 should not be selected
99-
$this->assertFalse($result[2]['selected']); // User 3 should not be selected
91+
$this->assertTrue($result[1]['selected']);
92+
$this->assertFalse($result[0]['selected']);
93+
$this->assertFalse($result[2]['selected']);
10094
}
10195

10296
public function testGetAllUsersForTemplateWithAllowBlockedUsers(): void
10397
{
104-
// Arrange
10598
$userIds = [1, 2];
10699

107100
$this->userMock
@@ -124,17 +117,14 @@ public function testGetAllUsersForTemplateWithAllowBlockedUsers(): void
124117
->method('getLogin')
125118
->willReturnOnConsecutiveCalls('active', 'blocked');
126119

127-
// Act
128120
$result = $this->userHelper->getAllUsersForTemplate(1, true);
129121

130-
// Assert
131122
$this->assertCount(2, $result);
132123
}
133124

134125
public function testGetAllUsersForTemplateSkipsInvalidUserId(): void
135126
{
136-
// Arrange
137-
$userIds = [1, -1, 2]; // -1 should be skipped
127+
$userIds = [1, -1, 2];
138128

139129
$this->userMock
140130
->expects($this->once())
@@ -160,27 +150,22 @@ public function testGetAllUsersForTemplateSkipsInvalidUserId(): void
160150
->method('getLogin')
161151
->willReturnOnConsecutiveCalls('user1', 'user2');
162152

163-
// Act
164153
$result = $this->userHelper->getAllUsersForTemplate();
165154

166-
// Assert
167155
$this->assertCount(2, $result);
168156
$this->assertEquals(1, $result[0]['id']);
169157
$this->assertEquals(2, $result[1]['id']);
170158
}
171159

172160
public function testGetAllUsersForTemplateWithEmptyUserList(): void
173161
{
174-
// Arrange
175162
$this->userMock
176163
->expects($this->once())
177164
->method('getAllUsers')
178165
->willReturn([]);
179166

180-
// Act
181167
$result = $this->userHelper->getAllUsersForTemplate();
182168

183-
// Assert
184169
$this->assertEmpty($result);
185170
}
186171
}

0 commit comments

Comments
 (0)