Skip to content

Commit 9837c6d

Browse files
authored
Merge pull request #147 from threshold-network/use-yarn-18.5.0-in-slither
Set Node.js version to 18.15.0 We want to fix problem with the yarn build (hardhat compile) command sometimes not generating expected artifacts. The problem is caused by the process silently quitting, which is related to the used version of Node (as descibed in NomicFoundation/hardhat#3877). We've confirmed the problem is reproducible on v18.16.0, now we're downgrading to v18.15.0 to fix the issue.
2 parents 3ed292e + 9dd0d2f commit 9837c6d

File tree

1 file changed

+28
-7
lines changed

1 file changed

+28
-7
lines changed

.github/workflows/contracts.yaml

Lines changed: 28 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,10 @@ jobs:
5959

6060
- uses: actions/setup-node@v3
6161
with:
62-
node-version: "18.x"
62+
# Using fixed version, because 18.16 was sometimes causing issues with
63+
# artifacts generation during `hardhat compile` - see
64+
# https://github.com/NomicFoundation/hardhat/issues/3877
65+
node-version: "18.15.0"
6366
cache: "yarn"
6467

6568
- name: Install dependencies
@@ -83,7 +86,10 @@ jobs:
8386

8487
- uses: actions/setup-node@v3
8588
with:
86-
node-version: "18.x"
89+
# Using fixed version, because 18.16 was sometimes causing issues with
90+
# artifacts generation during `hardhat compile` - see
91+
# https://github.com/NomicFoundation/hardhat/issues/3877
92+
node-version: "18.15.0"
8793
cache: "yarn"
8894

8995
- name: Install dependencies
@@ -104,7 +110,10 @@ jobs:
104110

105111
- uses: actions/setup-node@v3
106112
with:
107-
node-version: "18.x"
113+
# Using fixed version, because 18.16 was sometimes causing issues with
114+
# artifacts generation during `hardhat compile` - see
115+
# https://github.com/NomicFoundation/hardhat/issues/3877
116+
node-version: "18.15.0"
108117
cache: "yarn"
109118

110119
- name: Install dependencies
@@ -124,7 +133,10 @@ jobs:
124133

125134
- uses: actions/setup-node@v3
126135
with:
127-
node-version: "18.x"
136+
# Using fixed version, because 18.16 was sometimes causing issues with
137+
# artifacts generation during `hardhat compile` - see
138+
# https://github.com/NomicFoundation/hardhat/issues/3877
139+
node-version: "18.15.0"
128140
cache: "yarn"
129141
registry-url: "https://registry.npmjs.org"
130142

@@ -193,7 +205,10 @@ jobs:
193205

194206
- uses: actions/setup-node@v3
195207
with:
196-
node-version: "18.x"
208+
# Using fixed version, because 18.16 was sometimes causing issues with
209+
# artifacts generation during `hardhat compile` - see
210+
# https://github.com/NomicFoundation/hardhat/issues/3877
211+
node-version: "18.15.0"
197212
cache: "yarn"
198213

199214
- name: Install needed dependencies
@@ -229,7 +244,10 @@ jobs:
229244

230245
- uses: actions/setup-node@v3
231246
with:
232-
node-version: "18.x"
247+
# Using fixed version, because 18.16 was sometimes causing issues with
248+
# artifacts generation during `hardhat compile` - see
249+
# https://github.com/NomicFoundation/hardhat/issues/3877
250+
node-version: "18.15.0"
233251
cache: "yarn"
234252
registry-url: "https://registry.npmjs.org"
235253

@@ -284,7 +302,10 @@ jobs:
284302

285303
- uses: actions/setup-node@v3
286304
with:
287-
node-version: "18"
305+
# Using fixed version, because 18.16 was sometimes causing issues with
306+
# artifacts generation during `hardhat compile` - see
307+
# https://github.com/NomicFoundation/hardhat/issues/3877
308+
node-version: "18.15.0"
288309
cache: "yarn"
289310

290311
- uses: actions/setup-python@v4

0 commit comments

Comments
 (0)