From 2f1fccde8dbaac0e009db1da1eea1ac9afedcaf7 Mon Sep 17 00:00:00 2001 From: "@tanya_r" Date: Fri, 19 Jun 2026 21:34:58 -0300 Subject: [PATCH] style: make three code comments timeless Drop slice and ticket references from code comments so they read as durable rationale rather than progress notes: the KYC orchestrator no longer says the provider reference is unpersisted 'in this slice', the decision rule controller drops the 'later slice' idempotency aside, and the KYC context test no longer references a closed sandbox issue. No behaviour change. --- .../kotlin/com/fincore/compliance/api/KycApiContextIT.kt | 3 +-- .../com/fincore/compliance/application/kyc/KycOrchestrator.kt | 2 +- .../com/fincore/decision/store/api/DecisionRuleController.kt | 2 +- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/services/compliance/src/integrationTest/kotlin/com/fincore/compliance/api/KycApiContextIT.kt b/services/compliance/src/integrationTest/kotlin/com/fincore/compliance/api/KycApiContextIT.kt index 4ee3658..04a5267 100644 --- a/services/compliance/src/integrationTest/kotlin/com/fincore/compliance/api/KycApiContextIT.kt +++ b/services/compliance/src/integrationTest/kotlin/com/fincore/compliance/api/KycApiContextIT.kt @@ -39,8 +39,7 @@ class KycApiContextIT( class TestBeans { @Bean fun jwtDecoder(): JwtDecoder = mockk() - // No in-tree KycProvider yet (sandbox is #239); a fake satisfies the orchestrator's dependency so the - // full web context boots. + // A fake KycProvider satisfies the orchestrator's dependency so the full web context boots in isolation. @Bean fun kycProvider(): KycProvider = object : KycProvider { override fun check(request: KycCheckRequest): KycCheckResult = KycCheckResult.Pending("ref-test") diff --git a/services/compliance/src/main/kotlin/com/fincore/compliance/application/kyc/KycOrchestrator.kt b/services/compliance/src/main/kotlin/com/fincore/compliance/application/kyc/KycOrchestrator.kt index fbcb9f5..6db1abc 100644 --- a/services/compliance/src/main/kotlin/com/fincore/compliance/application/kyc/KycOrchestrator.kt +++ b/services/compliance/src/main/kotlin/com/fincore/compliance/application/kyc/KycOrchestrator.kt @@ -14,7 +14,7 @@ import org.springframework.stereotype.Service * * Concurrent process calls on the same session resolve via the entity's optimistic lock: the loser's * OptimisticLockingFailureException propagates. Pending and InsufficientData leave the session in SCREENING (there is - * no PENDING status); a later re-screen advances it. The provider reference is not persisted in this slice. + * no PENDING status); a later re-screen advances it. The provider reference is not persisted. */ @Service class KycOrchestrator( diff --git a/services/decision/src/main/kotlin/com/fincore/decision/store/api/DecisionRuleController.kt b/services/decision/src/main/kotlin/com/fincore/decision/store/api/DecisionRuleController.kt index f27ac95..05e18ee 100644 --- a/services/decision/src/main/kotlin/com/fincore/decision/store/api/DecisionRuleController.kt +++ b/services/decision/src/main/kotlin/com/fincore/decision/store/api/DecisionRuleController.kt @@ -39,7 +39,7 @@ class DecisionRuleController( } // No Idempotency-Key here by design: versions are append-only and monotonic, so a retried publish creates - // a new, immutable version rather than corrupting state. The full idempotency subsystem is a later slice. + // a new, immutable version rather than corrupting state. @Operation(summary = "Publish a rule version", description = "Validates the DSL document and stores it as the new active version.") @PostMapping("/{ruleKey}/versions", consumes = [MediaType.APPLICATION_JSON_VALUE]) fun publishVersion(