Skip to content

Hard-deprecate data_frame() #817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
krlmlr opened this issue Oct 1, 2020 · 1 comment · May be fixed by #1622
Open

Hard-deprecate data_frame() #817

krlmlr opened this issue Oct 1, 2020 · 1 comment · May be fixed by #1622
Labels
help wanted ❤️ we'd love your help!
Milestone

Comments

@krlmlr
Copy link
Member

krlmlr commented Oct 1, 2020

now that we have vctrs::data_frame() .

Also review other functions.

@krlmlr krlmlr added this to the 4.0.0 milestone Oct 1, 2020
@krlmlr krlmlr added the help wanted ❤️ we'd love your help! label Mar 19, 2025
@moodymudskipper
Copy link

moodymudskipper commented Mar 22, 2025

The 'tibble' package uses the 'lifecycle' package to handle the deprecation cycle.

From ? deprecate_soft :

  • deprecate_soft() warns only if the deprecated function is called directly, i.e. a user is calling a function they wrote in the global environment or a developer is calling it in their package. It does not warn when called indirectly, i.e. the deprecation comes from code that you don't control.
  • deprecate_warn() warns unconditionally.
  • deprecate_stop() fails unconditionally.`

data_frame() contains a calls to deprecate_warn(), we want deprecate_stop() instead, the message should direct to tibble() for the creation of tibbles and vctrs::data_frame() for the creation of data frames. (+ Update in the NEWS).

@andreranza andreranza linked a pull request Mar 26, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted ❤️ we'd love your help!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants