Remove prompt_for_tracking_branch setting

Author: kaste

GitSavvy.sublime-settings

@@ -228,12 +228,6 @@
     */
     "max_items_in_tags_dashboard": -1,
 
-    /*
-        When set to `true`, GitSavvy will offer to set the upstream on `git: push`
-        when tracking branch is not configured.
-     */
-    "prompt_for_tracking_branch": true,
-
     /*
         When set to `true`, GitSavvy will automatically display more info about the
         current commit in a output panel.

core/commands/push.py

@@ -20,8 +20,6 @@
 
 START_PUSH_MESSAGE = "Starting push..."
 END_PUSH_MESSAGE = "Push complete."
-SET_UPSTREAM_PROMPT = ("You have not set an upstream for the active branch.  "
-                       "Would you like to set one?")
 CONFIRM_FORCE_PUSH = ("You are about to `git push {}`. Would you  "
                       "like to proceed?")
 
@@ -99,10 +97,7 @@ def run(self, local_branch_name=None, force=False, force_with_lease=False):
             else:
                 kont()
 
-        elif (
-            not self.savvy_settings.get("prompt_for_tracking_branch") or
-            sublime.ok_cancel_dialog(SET_UPSTREAM_PROMPT)
-        ):
+        else:
             self.window.run_command("gs_push_to_branch_name", {
                 "local_branch_name": local_branch.name,
                 "set_upstream": True,

docs/remotes.md

@@ -31,7 +31,7 @@ Like `git: pull from branch`, but rebasing on the remote branch instead of mergi
 
 ## `git: push`
 
-This command will push current branch to the tracking branch. If the tracking branch is not set, you will be asked to configure it unless `prompt_for_tracking_branch` is set to `false`. In that case, you will be prompted for a remote, then the current branch will be pushed to a remote branch with the same name.
+This command will push current branch to the tracking branch. If the tracking branch is not set, you will be prompted for a remote and a branch name.
 
 ## `git: push to branch`
 

github/commands/pull_request.py

@@ -19,10 +19,6 @@
     from GitSavvy.core.git_mixins.branches import Branch
 
 
-PUSH_PROMPT = ("You have not set an upstream for the active branch.  "
-               "Would you like to push to a remote?")
-
-
 class GsGithubPullRequestCommand(WindowCommand, git_mixins.GithubRemotesMixin, GitCommand):
 
     """
@@ -182,14 +178,10 @@ def run_async(self):
             return
 
         if not current_branch.tracking:
-            if (
-                not self.savvy_settings.get("prompt_for_tracking_branch")
-                or sublime.ok_cancel_dialog(PUSH_PROMPT)
-            ):
-                self.window.run_command("gs_github_push_and_create_pull_request", {
-                    "local_branch_name": current_branch.name,
-                    "set_upstream": True
-                })
+            self.window.run_command("gs_github_push_and_create_pull_request", {
+                "local_branch_name": current_branch.name,
+                "set_upstream": True
+            })
 
         elif (
             "ahead" in current_branch.tracking_status