You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
TODO: Remove the go.mod/go.sum in internal/tools once doing so doesn't break CI (e.g. once we drop support for go 1.19)
* builder/cc1as.h: fix typo found by 'make spell'
* GNUmakefile: remove exception for inbetween, fix instance now found by 'make spell'
* GNUmakefile: remove exception for programmmer, fix instance now found by 'make spell'
* go.mod: use updated misspell. GNUmakefile: add spellfix target, use it.
* ignore directories properly when invoking spellchecker.
* make spell: give internal/tools its own go.mod, as misspell requires newer go
* make lint: depend on tools and run the installed revive
(which was perhaps implied by the change that added revive to internal/tools,
but not required in GNUmakefile until we gave internal/tools its own temporary go.mod)
* .github: now that 'make spell' works well, run it from CI
* GNUmakefile: make spell now aborts if it finds misspelt words, so what it finds doesn't get lost in CI logs
* GNUmakefile: tools: avoid -C option on go generate to make test-llvm15-go119 circleci job happy, see
https://cs.opensource.google/go/go/+/2af48cbb7d85e5fdc635e75b99f949010c607786
* internal/tools/go.mod: fix format of go version to leave out patchlevel, else go complains.
Copy file name to clipboardExpand all lines: GNUmakefile
+11-6
Original file line number
Diff line number
Diff line change
@@ -949,20 +949,25 @@ endif
949
949
950
950
.PHONY: tools
951
951
tools:
952
-
go generate -C ./internal/tools -tags tools ./
952
+
cdinternal/tools && go generate -tags tools ./
953
953
954
954
.PHONY: lint
955
-
lint: ## Lint source tree
956
-
go run github.com/mgechev/revive -version
955
+
lint: tools ## Lint source tree
956
+
revive -version
957
957
# TODO: lint more directories!
958
958
# revive.toml isn't flexible enough to filter out just one kind of error from a checker, so do it with grep here.
959
959
# Can't use grep with friendly formatter. Plain output isn't too bad, though.
960
960
# Use 'grep .' to get rid of stray blank line
961
-
go run github.com/mgechev/revive -config revive.toml compiler/... src/{os,reflect}/*.go | grep -v "should have comment or be unexported"| grep '.'| awk '{print}; END {exit NR>0}'
961
+
revive -config revive.toml compiler/... src/{os,reflect}/*.go | grep -v "should have comment or be unexported"| grep '.'| awk '{print}; END {exit NR>0}'
0 commit comments