respond to commit comments

Author: Lauren Long

quickstarts/uppercase/README.md

@@ -22,7 +22,7 @@ To deploy and try out the sample:
 
 ## Run unit tests
 
-The test folder has unit tests written with `firebase-functions-test`. There are 2 sets of tests: online and offline.
+The test folder has unit tests written with [`firebase-functions-test`](https://github.com/Firebase/firebase-functions-test). There are 2 sets of tests: online and offline.
 
 To run the offline tests: run `npm test` inside the functions folder.
 

quickstarts/uppercase/functions/test/test.offline.js

@@ -31,7 +31,7 @@ const admin = require('firebase-admin');
 const test = require('firebase-functions-test')();
 
 describe('Cloud Functions', () => {
-  var myFunctions, adminInitStub;
+  const myFunctions, adminInitStub;
 
   before(() => {
     // [START stubAdminInit]
@@ -75,7 +75,7 @@ describe('Cloud Functions', () => {
           }
         }
       };
-      childStub.withArgs(childParam).returns( { set: setStub });
+      childStub.withArgs(childParam).returns({ set: setStub });
       setStub.withArgs(setParam).returns(true);
       // [END fakeSnap]
       // Wrap the makeUppercase function.

quickstarts/uppercase/functions/test/test.online.js

@@ -33,7 +33,7 @@ const projectConfig = {
 const test = require('firebase-functions-test')(projectConfig, './service-account-key.json');
 
 describe('Cloud Functions', () => {
-  var myFunctions;
+  const myFunctions;
 
   before(() => {
     // Require index.js and save the exports inside a namespace called myFunctions.
@@ -83,7 +83,7 @@ describe('Cloud Functions', () => {
           // Assert code is 303
           assert.equal(code, 303);
           // If the database push is successful, then the URL sent back will have the following format:
-          var expectedRef = new RegExp(projectConfig.databaseURL + '/messages/');
+          const expectedRef = new RegExp(projectConfig.databaseURL + '/messages/');
           assert.isTrue(expectedRef.test(url));
           done();
         }