Skip to content

Commit 8519859

Browse files
author
Lauren Long
committed
respond to commit comments
1 parent c9d7c94 commit 8519859

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

quickstarts/uppercase/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ To deploy and try out the sample:
2222

2323
## Run unit tests
2424

25-
The test folder has unit tests written with `firebase-functions-test`. There are 2 sets of tests: online and offline.
25+
The test folder has unit tests written with [`firebase-functions-test`](https://github.com/Firebase/firebase-functions-test). There are 2 sets of tests: online and offline.
2626

2727
To run the offline tests: run `npm test` inside the functions folder.
2828

quickstarts/uppercase/functions/test/test.offline.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ const admin = require('firebase-admin');
3131
const test = require('firebase-functions-test')();
3232

3333
describe('Cloud Functions', () => {
34-
var myFunctions, adminInitStub;
34+
const myFunctions, adminInitStub;
3535

3636
before(() => {
3737
// [START stubAdminInit]
@@ -75,7 +75,7 @@ describe('Cloud Functions', () => {
7575
}
7676
}
7777
};
78-
childStub.withArgs(childParam).returns( { set: setStub });
78+
childStub.withArgs(childParam).returns({ set: setStub });
7979
setStub.withArgs(setParam).returns(true);
8080
// [END fakeSnap]
8181
// Wrap the makeUppercase function.

quickstarts/uppercase/functions/test/test.online.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ const projectConfig = {
3333
const test = require('firebase-functions-test')(projectConfig, './service-account-key.json');
3434

3535
describe('Cloud Functions', () => {
36-
var myFunctions;
36+
const myFunctions;
3737

3838
before(() => {
3939
// Require index.js and save the exports inside a namespace called myFunctions.
@@ -83,7 +83,7 @@ describe('Cloud Functions', () => {
8383
// Assert code is 303
8484
assert.equal(code, 303);
8585
// If the database push is successful, then the URL sent back will have the following format:
86-
var expectedRef = new RegExp(projectConfig.databaseURL + '/messages/');
86+
const expectedRef = new RegExp(projectConfig.databaseURL + '/messages/');
8787
assert.isTrue(expectedRef.test(url));
8888
done();
8989
}

0 commit comments

Comments
 (0)