Skip to content

Sessions with zoomed panes now start to lose its zoom state when refocused #316

@oblitum

Description

@oblitum

First time I see this behavior, must be due to the recent changes.

With at least two sessions open, chose one and have multiple panes open on it. Zoom one of the panes (prefix + z) and then switch to another session. Now switch back to the session with the zoomed pane. On switching back the zoom state is lost.

  • tmuxp load -d ./foo.yaml
  • tmux 2.6
  • tmuxp 1.3.5
  • libtmux 0.7.7

Activity

oblitum

oblitum commented on Nov 10, 2017

@oblitum
Author

I'm getting a tmux message when switching back: "no previous window".

oblitum

oblitum commented on Nov 10, 2017

@oblitum
Author

The session must be created by tmuxp, I'm using this one:

session_name: foo
windows:
- layout: main-vertical
  options:
    main-pane-width: 160
  panes:
  - blank
  - blank
  - blank

I start it from inside a tmux session (tmuxp load -y ./foo.yaml, -y or -d doesn't matter). I've noticed that I do get this message "no previous window", right when I start and enter the session with tmuxp load -y ./foo.yaml, prior to applying zoom, etc.

oblitum

oblitum commented on Nov 10, 2017

@oblitum
Author

The message "no previous window" always shows up when switching to tmuxp created sessions. Not only it shows up, I've noticed there's now quite a delay for the layout to load up when running tmuxp load -y ./foo.yaml. It spends some seconds in a blank state before the layout loads.

tony

tony commented on Nov 13, 2017

@tony
Member

With at least two sessions open, chose one and have multiple panes open on it. Zoom one of the panes (prefix + z) and then switch to another session. Now switch back to the session with the zoomed pane. On switching back the zoom state is lost.

I can't recreate it. My zoom is preserved.

I start it from inside a tmux session (tmuxp load -y ./foo.yaml, -y or -d doesn't matter). I've noticed that I do get this message "no previous window", right when I start and enter the session with tmuxp load -y ./foo.yaml, prior to applying zoom, etc.

I tried the yaml (on this machine, it's tmux 2.5 and the left pane is massive), and couldn't recreate the zoom glitch.

I believe it's happening to you, I just haven't been able to recreate it yet.

tony

tony commented on Nov 13, 2017

@tony
Member

I should try it on tmux 2.6.

oblitum

oblitum commented on Nov 21, 2017

@oblitum
Author

Missing zoom is secondary. it's lost because tmux is always emitting the error message "no previous window" at the bottom, which should reset the layout. There's also the issue regarding slower layout loading. For now I'm just pinned to tmuxp 1.3.2.

stale

stale commented on Jan 20, 2018

@stale

This issue has been automatically marked as stale because it has not had
recent activity. It will be closed if no further activity occurs. Thank you
for your contributions.

This bot is used to handle issues where the issue hasn't been discussed or
has gone out of date. If an issue isn't resolved and handled in a certain
period of time, it may be closed. If you would like your issue re-opened,
please create a fresh issue with the latest, up to date information and
mention this issue in it.

reopened this on Apr 1, 2018
added and removed on Apr 1, 2018
tony

tony commented on Apr 1, 2018

@tony
Member

Reopening

Is this the issue preventing you from using tmuxp at the latest version?

tony

tony commented on Apr 1, 2018

@tony
Member

Just to make sure, you can still load the windows/panes via tmuxp. But the session zoom breaks the zoom state after tmuxp loads it, and it started happening after the hook added when fixing #312?

it's lost because tmux is always emitting the error message "no previous window" at the bottom, which should reset the layout. There's also the issue regarding slower layout loading. For now I'm just pinned to tmuxp 1.3.2.

Got it. So if #364 is fixed, this should be fixed?

oblitum

oblitum commented on Apr 1, 2018

@oblitum
Author

Got it. So if #364 is fixed, this should be fixed?

Most probably yes.

oblitum

oblitum commented on Apr 1, 2018

@oblitum
Author

#364 is just a reopened duplicate of this one due to the stale bot.

oblitum

oblitum commented on Apr 1, 2018

@oblitum
Author

I thought #364 description was pretty clear on that...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @tony@oblitum

        Issue actions

          Sessions with zoomed panes now start to lose its zoom state when refocused · Issue #316 · tmux-python/tmuxp