Feat(duckdb)!: support transpilation of SHA256 from bigquery to duckdb #6421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sqlglot/dialects/dialect.py
Outdated
Comment on lines
1876
to
1877
| def build_sha2_digest_sql(self: Generator, expression: exp.SHA2Digest) -> str: | ||
| return self.func(f"SHA{expression.text('length') or '256'}", expression.this) |
Collaborator
There was a problem hiding this comment.
Rename this to sha2_digest_sql, otherwise naming clashes with AST helper builders.
Collaborator
Author
There was a problem hiding this comment.
updated
Comment on lines
+222
to
+224
| exp.SHA2Digest: lambda self, e: self.func( | ||
| "SHA2", e.this, e.args.get("length") or exp.Literal.number(256) | ||
| ), |
Collaborator
There was a problem hiding this comment.
Is there a bug in how exp.SHA2 is generated in redshift? Why did we need this entry and not reuse the new sha2_digest_sql helper?
Collaborator
Author
There was a problem hiding this comment.
so in redshift it should be something like SHA2('abc', 256), while sha2_digest_sql produces SHA256('abc)
Comment on lines
+285
to
+287
| exp.SHA2Digest: lambda self, e: self.func( | ||
| "SHA2", e.this, e.args.get("length") or exp.Literal.number(256) | ||
| ), |
Collaborator
There was a problem hiding this comment.
Ditto, similar to Redshift.
Collaborator
Author
There was a problem hiding this comment.
like redshift, spark2 also only has SHA2 function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When parsing SHA256 from BigQuery, we want to represent it as SHA2Digest with length 256 since the output is binary, just like we do with SHA1.
We also want to wrap SHA256 with UNHEX in the transpiled DuckDB query so that the output is binary to stay consistent with BigQuery.
For other dialects, we just want to make sure SHA2Digest with length 256 generates the appropriate queries. For example, SHA256(x) in bigquery should be tranpiled into SHA2_BINARY(x, 256) in Snowflake