remove Insights-specific logic and update comment (github#26483)

Co-authored-by: Grace Park <[email protected]>

Author: sarahs

middleware/contextualizers/generic-toc.js

@@ -30,16 +30,16 @@ export default async function genericToc(req, res, next) {
     req.pagePath
   )
 
-  // Do not include hidden child items on a TOC page unless it's an Early Access category page.
-  // We need to account for the extra 'articles' segment with Early Access as well, we don't
-  // want to show hidden child items in that case.
-  req.context.showHiddenTocItems =
-    (req.context.page.documentType === 'category' &&
-      req.context.currentPath.includes('/early-access/') &&
-      !req.context.currentPath.endsWith('/articles')) ||
-    (req.context.page.documentType === 'product' &&
-      req.context.currentPath.includes('/early-access/') &&
-      req.context.page.shortTitle === 'GitHub Insights')
+  // Only include hidden child items on a TOC page if it's an Early Access category or
+  // map topic page, not a product or 'articles' fake cagegory page (e.g., /early-access/github/articles).
+  // This is because we don't want entire EA product TOCs to be publicly browseable, but anything at the category
+  // or below level is fair game because that content is scoped to specific features.
+  const isCategoryOrMapTopic =
+    req.context.page.documentType === 'category' || req.context.page.documentType === 'mapTopic'
+  const isEarlyAccess = req.context.currentPath.includes('/early-access/')
+  const isArticlesCategory = req.context.currentPath.endsWith('/articles')
+
+  req.context.showHiddenTocItems = isCategoryOrMapTopic && isEarlyAccess && !isArticlesCategory
 
   // Conditionally run getTocItems() recursively.
   let isRecursive
@@ -77,6 +77,7 @@ async function getTocItems(pagesArray, context, isRecursive, renderIntros) {
   return (
     await Promise.all(
       pagesArray.map(async (child) => {
+        // only include a hidden page if showHiddenTocItems is true
         if (child.page.hidden && !context.showHiddenTocItems) return
 
         return {