Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regexp/Delete too aggressive? #89

Open
justinaray opened this issue Dec 6, 2016 · 1 comment
Open

Regexp/Delete too aggressive? #89

justinaray opened this issue Dec 6, 2016 · 1 comment

Comments

@justinaray
Copy link

Looking at the source and my head tag, it looks like all of my supplemental icon links are being removed. Specifically, this includes the apple-touch-icon[-precomposed].

Is this necessary to ensure the tinycon dynamic icon is applied on all platforms? Would it be possible to whitelist in some rel types that shouldn't be removed?

tinycon is 💯 btw!
@justinaray
Copy link
Author

Using document.querySelectorAll('head link[rel~="icon"]') could also be an approach instead of whitelisting. It would select just link tags that contain an icon string in the rel attribute.

Presumably, it would be acceptable to remove all of these tags as they are favicon candidates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@justinaray