Update available challenge statuses

Author: ThomasKranitsas

app-constants.js

@@ -16,9 +16,17 @@ const prizeSetTypes = {
 const challengeStatuses = {
   New: 'New',
   Draft: 'Draft',
-  Canceled: 'Canceled',
+  Cancelled: 'Cancelled',
   Active: 'Active',
-  Completed: 'Completed'
+  Completed: 'Completed',
+  Deleted: 'Deleted',
+  CancelledFailedReview: 'Cancelled - Failed Review',
+  CancelledFailedScreening: 'Cancelled - Failed Screening',
+  CancelledZeroSubmissions: 'Cancelled - Zero Submissions',
+  CancelledWinnerUnresponsive: 'Cancelled - Winner Unresponsive',
+  CancelledClientRequest: 'Cancelled - Client Request',
+  CancelledRequirementsInfeasible: 'Cancelled - Requirements Infeasible',
+  CancelledZeroRegistrations: 'Cancelled - Zero Registrations'
 }
 
 const validChallengeParams = {

docs/swagger.yaml

@@ -129,7 +129,7 @@ paths:
           description: Filter by status, case-insensitive, partial matches are allowed.
           required: false
           type: string
-          enum: ['New', 'Draft', 'Canceled', 'Active', 'Completed']
+          enum: ['New', 'Draft', 'Cancelled', 'Active', 'Completed']
         - name: currentPhaseId
           in: query
           description: Filter by id of the current phase
@@ -1858,7 +1858,7 @@ definitions:
       status:
         type: string
         description: the status
-        enum: ['New', 'Draft', 'Canceled', 'Active', 'Completed']
+        enum: ['New', 'Draft', 'Cancelled', 'Active', 'Completed']
       attachments:
         type: array
         items:
@@ -2160,7 +2160,7 @@ definitions:
       status:
         type: string
         description: the status
-        enum: ['New', 'Draft', 'Canceled', 'Active', 'Completed']
+        enum: ['New', 'Draft', 'Cancelled', 'Active', 'Completed']
       groups:
         type: array
         items:
@@ -2256,7 +2256,7 @@ definitions:
       status:
         type: string
         description: the status
-        enum: ['New', 'Draft', 'Canceled', 'Active', 'Completed']
+        enum: ['New', 'Draft', 'Cancelled', 'Active', 'Completed']
       attachments:
         type: array
         items:

src/services/ChallengeService.js

@@ -763,7 +763,7 @@ async function update (currentUser, challengeId, data, userToken, isFull) {
   }
 
   await validateChallengeData(data)
-  if ((challenge.status === constants.challengeStatuses.Completed || challenge.status === constants.challengeStatuses.Canceled) && data.status && data.status !== challenge.status) {
+  if ((challenge.status === constants.challengeStatuses.Completed || challenge.status === constants.challengeStatuses.Cancelled) && data.status && data.status !== challenge.status) {
     throw new errors.BadRequestError(`Cannot change ${challenge.status} challenge status to ${data.status} status`)
   }
 

test/e2e/challenge.api.test.js

@@ -475,7 +475,7 @@ describe('challenge API E2E tests', () => {
         .set('Authorization', `Bearer ${config.M2M_UPDATE_ACCESS_TOKEN}`)
         .send(challengeData)
       should.equal(response.status, 400)
-      should.equal(response.body.message, '"status" must be one of [New, Draft, Canceled, Active, Completed]')
+      should.equal(response.body.message, '"status" must be one of [New, Draft, Cancelled, Active, Completed]')
     })
 
     it('create challenge - unexpected field', async () => {
@@ -896,7 +896,7 @@ describe('challenge API E2E tests', () => {
         .set('Authorization', `Bearer ${config.ADMIN_TOKEN}`)
         .query({ status: 'abc' })
       should.equal(response.status, 400)
-      should.equal(response.body.message, '"status" must be one of [New, Draft, Canceled, Active, Completed]')
+      should.equal(response.body.message, '"status" must be one of [New, Draft, Cancelled, Active, Completed]')
     })
 
     it('search challenges - invalid createdDateStart', async () => {