File tree 2 files changed +15
-11
lines changed
lib/components/ReviewerList
review-management/ManageReviewerPage 2 files changed +15
-11
lines changed Original file line number Diff line number Diff line change @@ -43,7 +43,7 @@ const ApproveButton: FC<{
43
43
const isApproving = props . approvingReviewerId === props . reviewer . userId
44
44
const isOtherApproving = props . approvingReviewerId > 0
45
45
const hideApproveButton
46
- = props . openReviews < 1 || props . reviewer . applicationStatus === 'Approved '
46
+ = props . openReviews < 1 || props . reviewer . applicationStatus !== 'Pending '
47
47
48
48
return (
49
49
< >
@@ -157,10 +157,10 @@ const ReviewerList: FC<ReviewerListProps> = props => {
157
157
{
158
158
label : 'Open Review Opp' ,
159
159
propertyName : '' ,
160
- renderer : ( ) => (
160
+ renderer : ( reviewer : Reviewer ) => (
161
161
// eslint-disable-next-line jsx-a11y/anchor-is-valid
162
162
< div className = { styles . openReviews } >
163
- { props . openReviews }
163
+ { reviewer . currentNumberOfReviewPositions }
164
164
</ div >
165
165
) ,
166
166
type : 'element' ,
Original file line number Diff line number Diff line change @@ -104,6 +104,14 @@ export const ManageReviewerPage: FC = () => {
104
104
} )
105
105
} )
106
106
107
+ const newSearch = useEventCallback ( ( ) : void => {
108
+ doNewSearch ( )
109
+ . then ( data => {
110
+ setReviewers ( data )
111
+ window . scrollTo ( { left : 0 , top : 0 } )
112
+ } )
113
+ } )
114
+
107
115
const sortData = useEventCallback ( ( ) => {
108
116
doSortData ( )
109
117
. then ( data => {
@@ -114,19 +122,15 @@ export const ManageReviewerPage: FC = () => {
114
122
115
123
const reject = useEventCallback ( ( ) : void => {
116
124
doReject ( )
117
- . then ( res => {
118
- if ( res ) {
119
- doNewSearch ( )
120
- }
125
+ . then ( ( ) => {
126
+ newSearch ( )
121
127
} )
122
128
} )
123
129
124
130
const approve = useEventCallback ( ( reviewer : Reviewer ) : void => {
125
131
doApprove ( reviewer )
126
- . then ( res => {
127
- if ( res ) {
128
- doNewSearch ( )
129
- }
132
+ . then ( ( ) => {
133
+ newSearch ( )
130
134
} )
131
135
} )
132
136
You can’t perform that action at this time.
0 commit comments