Skip to content

Commit 1e47bf8

Browse files
authored
Merge pull request #1023 from topcoder-platform/diazz-f2f-30376447
Review Application Bug Fix
2 parents 0efe737 + afab032 commit 1e47bf8

File tree

2 files changed

+15
-11
lines changed

2 files changed

+15
-11
lines changed

src/apps/admin/src/lib/components/ReviewerList/ReviewerList.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ const ApproveButton: FC<{
4343
const isApproving = props.approvingReviewerId === props.reviewer.userId
4444
const isOtherApproving = props.approvingReviewerId > 0
4545
const hideApproveButton
46-
= props.openReviews < 1 || props.reviewer.applicationStatus === 'Approved'
46+
= props.openReviews < 1 || props.reviewer.applicationStatus !== 'Pending'
4747

4848
return (
4949
<>
@@ -157,10 +157,10 @@ const ReviewerList: FC<ReviewerListProps> = props => {
157157
{
158158
label: 'Open Review Opp',
159159
propertyName: '',
160-
renderer: () => (
160+
renderer: (reviewer: Reviewer) => (
161161
// eslint-disable-next-line jsx-a11y/anchor-is-valid
162162
<div className={styles.openReviews}>
163-
{props.openReviews}
163+
{reviewer.currentNumberOfReviewPositions}
164164
</div>
165165
),
166166
type: 'element',

src/apps/admin/src/review-management/ManageReviewerPage/ManageReviewerPage.tsx

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,14 @@ export const ManageReviewerPage: FC = () => {
104104
})
105105
})
106106

107+
const newSearch = useEventCallback((): void => {
108+
doNewSearch()
109+
.then(data => {
110+
setReviewers(data)
111+
window.scrollTo({ left: 0, top: 0 })
112+
})
113+
})
114+
107115
const sortData = useEventCallback(() => {
108116
doSortData()
109117
.then(data => {
@@ -114,19 +122,15 @@ export const ManageReviewerPage: FC = () => {
114122

115123
const reject = useEventCallback((): void => {
116124
doReject()
117-
.then(res => {
118-
if (res) {
119-
doNewSearch()
120-
}
125+
.then(() => {
126+
newSearch()
121127
})
122128
})
123129

124130
const approve = useEventCallback((reviewer: Reviewer): void => {
125131
doApprove(reviewer)
126-
.then(res => {
127-
if (res) {
128-
doNewSearch()
129-
}
132+
.then(() => {
133+
newSearch()
130134
})
131135
})
132136

0 commit comments

Comments
 (0)