Merge pull request #984 from topcoder-platform/PM-460_handle-security-scan-issues

PM-460 - handle scurity scan issues

Author: vas3a

src/apps/earn/src/config/dev.ts

@@ -9,7 +9,7 @@ const DevEarnConfig: EarnConfig = {
     /* Max number of recommended challenges */
     CHALLENGE_DETAILS_MAX_NUMBER_RECOMMENDED_CHALLENGES: 3,
 
-    SERVER_API_KEY: '79b2d5eb-c1fd-42c4-9391-6b2c9780d591',
+    SERVER_API_KEY: process.env.REACT_APP_LOG_SERVER_API_KEY as string,
 
     API: {
         V2: 'https://api.topcoder-dev.com/v2',

src/apps/earn/src/config/prod.ts

@@ -11,7 +11,7 @@ const ProdEarnConfig: EarnConfig = {
     /**
    * URL of Topcoder Connect Website
    */
-    SERVER_API_KEY: 'aa9ccf36-3936-450c-9983-097ddba51bef',
+    SERVER_API_KEY: process.env.REACT_APP_LOG_SERVER_API_KEY as string,
     API: {
         V2: 'https://api.topcoder-dev.com/v2',
         V3: 'https://api.topcoder-dev.com/v3',

src/apps/earn/src/utils/logger.js

@@ -33,6 +33,10 @@ _.functions(console).forEach((func) => {
 let leLogger;
 
 const log = (type, ...rest) => {
+  if (!config.SERVER_API_KEY) {
+    return;
+  }
+
   fetch("/community-app-assets/api/logger", {
     body: JSON.stringify({
       data: rest,

src/apps/learn/src/course-details/course-curriculum/dice-modal/DiceModal.tsx

@@ -2,6 +2,7 @@ import { Dispatch, FC, SetStateAction, useEffect, useState } from 'react'
 
 import { EnvironmentConfig } from '~/config'
 import { BaseModal, Button } from '~/libs/ui'
+import { preventDefault } from '~/apps/earn/src/utils/misc'
 
 import styles from './DiceModal.module.scss'
 
@@ -49,7 +50,7 @@ const DiceModal: FC<DiceModalProps> = (props: DiceModalProps) => {
                     click below to refresh your settings.
                 </p>
                 <p className={styles.buttonContainer}>
-                    <a href={window.location.href}>
+                    <a href='#refresh-settings' onClick={preventDefault}>
                         <Button
                             secondary
                             label='Refresh Settings'

src/apps/learn/src/free-code-camp/fcc-frame/FccFrame.tsx

@@ -38,7 +38,7 @@ const FccFrame: FC<FccFrameProps> = (props: FccFrameProps) => {
             frameRef.current.contentWindow.postMessage(JSON.stringify({
                 data: { path: `/${lessonUrl}` },
                 event: 'fcc:url:update',
-            }), '*')
+            }), LearnConfig.CLIENT)
         }
         // eslint-disable-next-line react-hooks/exhaustive-deps
     }, [

src/apps/self-service/src/components/work-details/details/sidebar/WorkDetailDetailsSidebar.tsx

@@ -40,7 +40,7 @@ const WorkDetailDetailsSidebar: FC<{}> = () => {
                 <h4>supporting information</h4>
                 <a
                     className={styles.link}
-                    href={window.location.href}
+                    href='#1'
                     onClick={getClickHandler(setIsOrderContractModalOpen)}
                     rel='noopener noreferrer'
                     role='button'
@@ -50,7 +50,7 @@ const WorkDetailDetailsSidebar: FC<{}> = () => {
                 </a>
                 <a
                     className={styles.link}
-                    href={window.location.href}
+                    href='#2'
                     onClick={getClickHandler(setIsPrivacyPolicyModalOpen)}
                     rel='noopener noreferrer'
                     role='button'
@@ -60,7 +60,7 @@ const WorkDetailDetailsSidebar: FC<{}> = () => {
                 </a>
                 <a
                     className={styles.link}
-                    href={window.location.href}
+                    href='#3'
                     onClick={getClickHandler(setIsTermsModalOpen)}
                     rel='noopener noreferrer'
                     role='button'