Merge pull request #1201 from topcoder-platform/pm-1503_2

fix(PM-1503): QA feedbacks in view scorecard page

Author: kkartunov

.circleci/config.yml

@@ -223,7 +223,7 @@ workflows:
                               - CORE-635
                               - feat/review
                               - feat/system-admin
-                              - pm-1365_1
+                              - pm-1503_2
 
             - deployQa:
                   context: org-global

src/apps/review/src/lib/hooks/useFetchScorecard.ts

@@ -1,3 +1,4 @@
+import { toast } from 'react-toastify'
 import useSWR, { SWRResponse } from 'swr'
 
 import { EnvironmentConfig } from '~/config'
@@ -21,6 +22,11 @@ export function useFetchScorecard(id: string | undefined): ScorecardResponse {
         // eslint-disable-next-line unicorn/no-null
         id ? `${baseUrl}/scorecards/${id}` : null,
         fetcher,
+        {
+            onError: err => {
+                toast.error(err.message)
+            },
+        },
     )
 
     return {

src/apps/review/src/pages/scorecards/ViewScorecardPage/ScorecardDetails/ScorecardDetails.module.scss

@@ -1,3 +1,5 @@
+@import '@libs/ui/styles/includes';
+
 .container {
     display: flex;
     flex-direction: row;
@@ -50,4 +52,10 @@
             flex-direction: column;
         }
     }
-}
+}
+
+@media (max-width: #{$lg-max}) {
+    .container {
+        flex-direction: column;
+    }
+}

src/apps/review/src/pages/scorecards/ViewScorecardPage/ScorecardGroups/ScorecardGroups.module.scss

@@ -37,9 +37,9 @@
         .group {
             .heading {
                 .groupInfo {
-                    flex-direction: column;
+                    flex-direction: row;
                     .name {
-                        margin-bottom: 8px;
+                        margin-bottom: 0px;
                     }
                 }
             }

src/apps/review/src/pages/scorecards/ViewScorecardPage/ScorecardSections/ScorecardSections.module.scss

@@ -80,15 +80,15 @@
         .section {
             .heading {
                 .sectionInfo {
-                    flex-direction: column;
+                    flex-direction: row;
                     .name {
-                        margin-bottom: 4px;
+                        margin-bottom: 0px;
                     }
                 }
             }
             .questions { 
                 .question {
-                    flex-direction: column;
+                    flex-direction: row;
                     .left {
                         .detailItemsWrapper {
                             .detailItem {

src/apps/review/src/pages/scorecards/ViewScorecardPage/ViewScorecardPage.tsx

@@ -20,15 +20,15 @@ const ViewScorecardPage: FC = () => {
     const { profile }: ProfileContextData = useContext(profileContext)
     const isAdmin = profile?.roles.includes(UserRole.administrator)
     const breadCrumb = useMemo(
-        () => [{ index: 1, label: 'Scorecards', path: '/review/scorecard' }, { index: 2, label: 'Scorecards Details' }],
+        () => [{ index: 1, label: 'Scorecards', path: '/scorecard' }, { index: 2, label: 'Scorecards Details' }],
         [],
     )
 
     const scorecardQuery = useFetchScorecard(scorecardId)
 
     return (
         <PageWrapper
-            pageTitle='Software General Review Scorecard'
+            pageTitle={(scorecardQuery.scorecard && scorecardQuery.scorecard.name) || ''}
             breadCrumb={breadCrumb}
             rightHeader={isAdmin && (
                 <LinkButton

src/apps/review/src/review-app.routes.tsx

@@ -101,7 +101,6 @@ export const reviewRoutes: ReadonlyArray<PlatformRoute> = [
                 route: activeReviewAssigmentsRouteId,
             },
             {
-                authRequired: true,
                 children: [
                     {
                         authRequired: true,
@@ -110,21 +109,23 @@ export const reviewRoutes: ReadonlyArray<PlatformRoute> = [
                         route: '',
                     },
                     {
-                        authRequired: false,
-                        element: <ViewScorecardPage />,
-                        id: 'view-scorecard-page',
-                        route: ':scorecardId',
-                    },
-                    {
+                        authRequired: true,
                         element: <EditScorecardPage />,
                         id: 'edit-scorecard-page',
                         route: ':scorecardId/edit',
                     },
                     {
+                        authRequired: true,
                         element: <EditScorecardPage />,
                         id: 'new-scorecard-page',
                         route: 'new',
                     },
+                    {
+                        authRequired: false,
+                        element: <ViewScorecardPage />,
+                        id: 'view-scorecard-page',
+                        route: ':scorecardId',
+                    },
 
                 ],
                 element: <ScorecardsContainer />,