Skip to content

Commit d0f3439

Browse files
Merge pull request #1213 from topcoder-platform/fix-pm-1612
PM-1612 Fix Applications tab view
2 parents c34a372 + 13c1cfd commit d0f3439

File tree

2 files changed

+5
-14
lines changed

2 files changed

+5
-14
lines changed

src/apps/copilots/src/pages/copilot-opportunity-details/index.tsx

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -86,12 +86,8 @@ const CopilotOpportunityDetails: FC<{}> = () => {
8686
const [activeTab, setActiveTab]: [string, Dispatch<SetStateAction<string>>] = useState<string>(activeTabHash)
8787

8888
useEffect(() => {
89-
if (isAdminOrPM) {
90-
setActiveTab(activeTabHash)
91-
} else {
92-
setActiveTab('0')
93-
}
94-
}, [activeTabHash, isAdminOrPM])
89+
setActiveTab(activeTabHash)
90+
}, [activeTabHash])
9591

9692
const handleTabChange = useCallback((tabId: string): void => {
9793
setActiveTab(tabId)
@@ -286,7 +282,7 @@ const CopilotOpportunityDetails: FC<{}> = () => {
286282
<TabsNavbar
287283
defaultActive={activeTab}
288284
onChange={handleTabChange}
289-
tabs={getCopilotDetailsTabsConfig(isAdminOrPM, copilotApplications?.length || 0)}
285+
tabs={getCopilotDetailsTabsConfig(copilotApplications?.length || 0)}
290286
/>
291287
)
292288
}
@@ -297,7 +293,7 @@ const CopilotOpportunityDetails: FC<{}> = () => {
297293
opportunity={opportunity}
298294
members={members}
299295
onApplied={onApplied}
300-
isAdminOrPM
296+
isAdminOrPM={isAdminOrPM}
301297
/>
302298
)}
303299

src/apps/copilots/src/pages/copilot-opportunity-details/tabs/config/copilot-details-tabs-config.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ export enum CopilotDetailsTabViews {
55
applications = '1',
66
}
77

8-
export const getCopilotDetailsTabsConfig = (isAdminOrPM: boolean, count: number): TabsNavItem[] => (isAdminOrPM ? [
8+
export const getCopilotDetailsTabsConfig = (count: number): TabsNavItem[] => ([
99
{
1010
id: CopilotDetailsTabViews.details,
1111
title: 'Details',
@@ -18,11 +18,6 @@ export const getCopilotDetailsTabsConfig = (isAdminOrPM: boolean, count: number)
1818
id: CopilotDetailsTabViews.applications,
1919
title: 'Applications',
2020
},
21-
] : [
22-
{
23-
id: CopilotDetailsTabViews.details,
24-
title: 'Details',
25-
},
2621
])
2722

2823
export const CopilotDetailsTabsConfig: TabsNavItem[] = [

0 commit comments

Comments
 (0)