Merge pull request #1590 from topcoder-platform/pm-225

PM-225 Fix privacy violation related to cookie

Author: hentrymartin

src/components/ChallengeEditor/ChallengeView/index.js

@@ -18,7 +18,6 @@ import ChallengeTotalField from '../ChallengeTotal-Field'
 import Loader from '../../Loader'
 import AssignedMemberField from '../AssignedMember-Field'
 import { getResourceRoleByName } from '../../../util/tc'
-import { isBetaMode } from '../../../util/cookie'
 import { loadGroupDetails } from '../../../actions/challenges'
 import {
   REVIEW_TYPES,
@@ -29,6 +28,7 @@ import {
 } from '../../../config/constants'
 import PhaseInput from '../../PhaseInput'
 import CheckpointPrizesField from '../CheckpointPrizes-Field'
+import { isBetaMode } from '../../../util/localstorage'
 
 const ChallengeView = ({
   projectDetail,

src/components/ChallengeEditor/index.js

@@ -69,11 +69,11 @@ import Tooltip from '../Tooltip'
 import CancelDropDown from './Cancel-Dropdown'
 import UseSchedulingAPIField from './UseSchedulingAPIField'
 
-import { isBetaMode } from '../../util/cookie'
 import MilestoneField from './Milestone-Field'
 import DiscussionField from './Discussion-Field'
 import CheckpointPrizesField from './CheckpointPrizes-Field'
 import { canChangeDuration } from '../../util/phase'
+import { isBetaMode } from '../../util/localstorage'
 
 const theme = {
   container: styles.modalContainer

src/routes.js

@@ -17,11 +17,11 @@ import { saveToken } from './actions/auth'
 import { loadChallengeDetails } from './actions/challenges'
 import { connect } from 'react-redux'
 import { checkAllowedRoles, checkOnlyReadOnlyRoles, checkReadOnlyRoles } from './util/tc'
-import { setCookie, removeCookie, isBetaMode } from './util/cookie'
 import IdleTimer from 'react-idle-timer'
 import modalStyles from './styles/modal.module.scss'
 import ConfirmationModal from './components/Modal/ConfirmationModal'
 import Users from './containers/Users'
+import { isBetaMode, removeFromLocalStorage, saveToLocalStorage } from './util/localstorage'
 
 const { ACCOUNTS_APP_LOGIN_URL, IDLE_TIMEOUT_MINUTES, IDLE_TIMEOUT_GRACE_MINUTES, COMMUNITY_APP_URL } = process.env
 
@@ -105,9 +105,9 @@ class Routes extends React.Component {
     const params = new URLSearchParams(search)
     if (!_.isEmpty(params.get('beta'))) {
       if (params.get('beta') === 'true' && !isBetaMode()) {
-        setCookie(BETA_MODE_COOKIE_TAG, 'true')
+        saveToLocalStorage(BETA_MODE_COOKIE_TAG, 'true')
       } else if (params.get('beta') === 'false' && isBetaMode()) {
-        removeCookie(BETA_MODE_COOKIE_TAG)
+        removeFromLocalStorage(BETA_MODE_COOKIE_TAG)
       }
       this.props.history.push(this.props.location.pathname)
     }

src/util/cookie.js

@@ -0,0 +1,61 @@
+import { BETA_MODE_COOKIE_TAG } from '../config/constants'
+
+/**
+ * Save an item to localStorage.
+ * @param {string} key - The key under which the data will be stored.
+ * @param {any} value - The data to store (will be stringified).
+ */
+export function saveToLocalStorage (key, value) {
+  if (!key || typeof key !== 'string') {
+    throw new Error('Key must be a valid string.')
+  }
+
+  try {
+    const jsonValue = JSON.stringify(value)
+    window.localStorage.setItem(key, jsonValue)
+  } catch (error) {
+    console.error('Failed to save to localStorage:', error)
+  }
+}
+
+/**
+* Get an item from localStorage.
+* @param {string} key - The key under which the data is stored.
+* @returns {any} - The parsed data from localStorage, or null if not found.
+*/
+export function getFromLocalStorage (key) {
+  if (!key || typeof key !== 'string') {
+    throw new Error('Key must be a valid string.')
+  }
+
+  try {
+    const jsonValue = window.localStorage.getItem(key)
+    return jsonValue ? JSON.parse(jsonValue) : null
+  } catch (error) {
+    console.error('Failed to retrieve from localStorage:', error)
+    return null
+  }
+}
+
+/**
+ * Remove an item from localStorage.
+ * @param {string} key - The key of the item to remove.
+ */
+export function removeFromLocalStorage (key) {
+  if (!key || typeof key !== 'string') {
+    throw new Error('Key must be a valid string.')
+  }
+
+  try {
+    window.localStorage.removeItem(key)
+  } catch (error) {
+    console.error('Failed to remove from localStorage:', error)
+  }
+}
+
+/**
+ * A function that checks whether beta mode is enabled or not
+ */
+export function isBetaMode () {
+  return getFromLocalStorage(BETA_MODE_COOKIE_TAG) === 'true'
+}