Unify how we scale modules

[fmartiescofet]

When using UperNet decoder with plain ViT decoder_scale_modules should be set to True to upscale the layers to simulate a "hierarchical output". This part can also be done in the LearnedInterpolateToPyramidal neck, in the tests for the Unet, which also needs this hierarchical output, this neck is used.
For this, I suggest deprecating scale_modules for the UperNetDecoder and recommend using the neck instead.

Also, we should consider the architecture for this neck as currently it only supports 4 layers and the last one is downscaled using maxpool, not sure if this is the best option and it might be interesting to look into it.

CC: @blumenstiel

[blumenstiel]

Thanks @fmartiescofet!

I agree, It is more inline with our architecture design to use necks instead of decoder specific settings. As you mentioned, the necks should also generalize better, by making it possible to configure the scaling (e.g. also scaling only 3 or 5 layers).

Also, the last layers should be scaled while the first layers are ignored. E.g. with 5 input laters and 4 scaling settings, the 1 laters gets passed. As Francesc explained it to me, smp_Unet required a additional 1. input layers that gets ignored.

[blumenstiel]

@fmartiescofet I think this is on hold until we remove the scale_modules in a later version, right?

[fmartiescofet]

Yes, but I think it should be removed before v1.0. Probably between 0.99.8 (if released) and 1.0.

Regarding the neck architecture I would leave it as it is to not confuse people and maybe add a different neck in case we want another archietcture.

[blumenstiel]

Sounds good.

@romeokienzler Another point why we should have another pre-release version.

[romeokienzler]

@blumenstiel scheduled for 1.2

[romeokienzler]

removed in #1095