Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable import key support for legacy networks and fix race condition for isNewKey flag #104

Open
himanshuchawla009 opened this issue Sep 4, 2024 · 1 comment
Assignees

Comments

@himanshuchawla009
Copy link
Member

himanshuchawla009 commented Sep 4, 2024

  • We have already disabled support for import keys in web sdks for legacy network as there are some edge cases which doesnt work well with legacy networks.

Please disable it here as well

Refer to: torusresearch/torus.js#158

Also above PR fixes a race condition in isNewKey check by moving away from threshold Check method

@metalurgical
Copy link
Collaborator

isNewKey fix:
#106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants