Add another ReadFromString method prototype for memory increase protection

Author: tpaviot

src/SWIG_files/wrapper/BRepTools.i

@@ -984,15 +984,24 @@ Parameter theProgress the range of progress indicator to fill in.
                         BRepTools::Write(shape, s);
                         return s.str();}
                     };
-                    %feature("autodoc", "Deserializes TopoDS_Shape from string") ReadFromString;
+                    %feature("autodoc", "Deserializes TopoDS_Shape from string. Create and return a new TopoDS_Shape each time the method is called.") ReadFromString;
                     %extend{
                         static TopoDS_Shape ReadFromString(const std::string & src) {
-                        std::stringstream s(src);
-                        TopoDS_Shape shape;
-                        BRep_Builder b;
-                        BRepTools::Read(shape, s, b);
-                        return shape;}
+                            std::istringstream s(std::move(src));
+                            TopoDS_Shape shape;
+                            BRep_Builder b;
+                            BRepTools::Read(shape, s, b);
+                            return shape;
+                        }
                     };
+                    %feature("autodoc", "Deserializes TopoDS_Shape from string. Take a TopoDS_Shape instance by reference to prevent memory increase.") ReadFromString;
+                    %extend{
+                        static void ReadFromString(const std::string & src, TopoDS_Shape& shape) {
+						    std::istringstream s(std::move(src));
+						    BRep_Builder b;
+						    BRepTools::Read(shape, s, b);
+						}
+                    };     
             };
 
 

test/test_core_wrapper_features.py

@@ -48,7 +48,7 @@
     BRepBuilderAPI_MakeEdge,
     BRepBuilderAPI_Sewing,
 )
-from OCC.Core.BRepTools import BRepTools_ShapeSet
+from OCC.Core.BRepTools import BRepTools_ShapeSet, breptools
 from OCC.Core.gp import (
     gp_Pnt,
     gp_Vec,
@@ -1218,3 +1218,18 @@ def test_breptools_shape_set_extensions():
         brep_string_content = f.read()
     new_shape_set = BRepTools_ShapeSet()
     new_shape_set.ReadFromString(brep_string_content)
+
+
+def test_topods_readfromstring_extension():
+    box = BRepPrimAPI_MakeBox(100, 100, 100).Shape()
+    string = breptools.WriteToString(box)
+
+    # create a new shape each time
+    for i in range(10):
+        box1 = breptools.ReadFromString(string)
+
+    # same, but fill in the shape
+    topods_shape = TopoDS_Shape()
+    # create a new shape each time
+    for i in range(10):
+        breptools.ReadFromString(string, topods_shape)