Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clang-tidy errors #52

Open
PeterZhizhin opened this issue Jul 7, 2020 · 0 comments
Open

Clang-tidy errors #52

PeterZhizhin opened this issue Jul 7, 2020 · 0 comments

Comments

@PeterZhizhin
Copy link

Hello! There seems to be a lot of clang-tidy errors when I copy-paste tqdm into my project.
There is a (not complete) list of them:

  1. error: 'tqdm::Tqdm<tqdm::RangeIterator<unsigned int> >' has virtual functions but non-virtual destructor.
  2. error: 'tqdm::MyIteratorWrapper<tqdm::RangeIterator<unsigned int> >' has virtual functions but non-virtual destructor
  3. A bunch of Declaration uses identifier '_Iterator' which is a reserved identifier.

Consider running clang-tidy on the project and fix all the errors. There are some significant issues like non-virtual destructors and returning copies from operators instead of returning references.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant