Skip to content

Commit 88df394

Browse files
committed
improvement to how options are added to default_configure_options
1 parent 2eae0b5 commit 88df394

File tree

5 files changed

+9
-7
lines changed

5 files changed

+9
-7
lines changed

.travis.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,7 @@ install:
9292
fi
9393
- ./bin/install-icu
9494
- export PKG_CONFIG_PATH=$ICU_INSTALL_DIR/lib/pkgconfig:$PKG_CONFIG_PATH
95+
- touch custom_configure_options
9596
- ./bin/install-libzip
9697
- ./bin/install-libsodium
9798
- ./bin/install-password-argon2
@@ -101,6 +102,7 @@ install:
101102
else
102103
cp default_configure_options.$RELEASE $HOME/.php-build/share/php-build/default_configure_options
103104
fi
105+
- cat custom_configure_options >> $HOME/.php-build/share/php-build/default_configure_options
104106
- | # disable xdebug on master
105107
if [[ $VERSION = master && $RELEASE != xenial ]]; then
106108
sed -i -e '/install_xdebug_master/d' $HOME/.php-build/share/php-build/definitions/$VERSION

bin/install-icu

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,5 +22,5 @@ popd
2222

2323
# PHP >= 7.4 exclusively uses pkg-config for ICU
2424
if [[ $VERSION =~ ^5 || $VERSION =~ 7\.[0123] ]]; then
25-
echo "--with-icu-dir=$ICU_INSTALL_DIR" >> $TRAVIS_BUILD_DIR/default_configure_options.${RELEASE}
25+
echo "--with-icu-dir=$ICU_INSTALL_DIR" >> $TRAVIS_BUILD_DIR/custom_configure_options
2626
fi

bin/install-libsodium

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,5 +20,5 @@ make check
2020
make install
2121
popd
2222

23-
# add the option in default_configure_options
24-
echo "--with-sodium=$LIBSODIUM_INSTALL_DIR" >> $TRAVIS_BUILD_DIR/default_configure_options.${RELEASE}
23+
# add the option in custom_configure_options
24+
echo "--with-sodium=$LIBSODIUM_INSTALL_DIR" >> $TRAVIS_BUILD_DIR/custom_configure_options

bin/install-libzip

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,5 +36,5 @@ make
3636
make install
3737
popd
3838

39-
# add the option in default_configure_options
40-
echo "--with-libzip=$LIBZIP_INSTALL_DIR" >> $TRAVIS_BUILD_DIR/default_configure_options.${RELEASE}
39+
# add the option in custom_configure_options
40+
echo "--with-libzip=$LIBZIP_INSTALL_DIR" >> $TRAVIS_BUILD_DIR/custom_configure_options

bin/install-password-argon2

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,5 +19,5 @@ make test
1919
make install PREFIX=$LIBARGON2_INSTALL_DIR
2020
popd
2121

22-
# add the option in default_configure_options
23-
echo "--with-password-argon2=$LIBARGON2_INSTALL_DIR" >> $TRAVIS_BUILD_DIR/default_configure_options.${RELEASE}
22+
# add the option in custom_configure_options
23+
echo "--with-password-argon2=$LIBARGON2_INSTALL_DIR" >> $TRAVIS_BUILD_DIR/custom_configure_options

0 commit comments

Comments
 (0)