fix user_sync/repositories to not explode on GH errors

Author: svenfuchs

lib/travis/github/services/sync_user/repositories.rb

@@ -90,14 +90,15 @@ def slugs
             end
 
             def fetch
-              resources.map { |resource| fetch_resource(resource) }.map(&:to_a).flatten.compact
+              resources.map { |resource| fetch_resource(resource) }.compact.map(&:to_a).flatten
             end
             instrument :fetch, :level => :debug
 
             def fetch_resource(resource)
               GH[resource] # TODO should be: ?type=#{self.class.type} but GitHub doesn't work as documented
             rescue GH::Error => e
               log_exception(e)
+              nil
             end
 
             def with_github(&block)

spec/travis/github/services/sync_user/repositories_spec.rb

@@ -127,6 +127,11 @@
       sync.run
     end
   end
+
+  it 'does not explode on GH errors' do
+    GH.expects(:[]).with('user/repos').raises(GH::Error.new)
+    expect { sync.run }.to_not raise_error
+  end
 end
 
 describe Travis::Github::Services::SyncUser::Repositories::Instrument do