This repository has been archived by the owner on Mar 25, 2023. It is now read-only.
Implement granularity control #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I'm just getting back from vacation, so I'll take a look at this once I've gotten things settled :) |
|
@trflynn89 any chance you could look at this again? |
|
Bump again? 😊 |
|
Happy new year! Is there anything else I can do to help this get merged? |
This reverts commit 8a48465.
francislavoie
force-pushed
the
granularity-setting
branch
from
4b7ecf5 to
8e6325d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3
I was bored tonight, so I decided to try to scratch my own itch.
This enables preferences for the extension, and adds a Granularity option which is a percentage step to increase/decrease the volume. Defaults to 5 which is the same as before. I like 2, personally.
You'll notice there's a binary file, I just followed the guide on https://gjs.guide/extensions/development/preferences.html#creating-the-schema which says we need to compile the prefs XML schema with the below command (if you want to verify that it matches on your system in case you don't trust the binary):