Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TpetraMultiVector test coverage #121

Closed
tjfulle opened this issue Nov 29, 2017 · 3 comments
Closed

TpetraMultiVector test coverage #121

tjfulle opened this issue Nov 29, 2017 · 3 comments
Assignees
Milestone

Comments

@tjfulle
Copy link
Collaborator

tjfulle commented Nov 29, 2017

No description provided.

@tjfulle tjfulle self-assigned this Nov 29, 2017
tjfulle added a commit to tjfulle/ForTrilinos that referenced this issue Nov 29, 2017
All tests now pass

One TODO: `Get1dCopy` could take fortran array instead of ArrayView

Related issue: trilinos#121
@tjfulle
Copy link
Collaborator Author

tjfulle commented Nov 29, 2017

PR #122 goes a long way to getting pretty complete test coverage for TpetraMultiVector. There are many "skeleton" tests in test_tpetra_multivector.f90 that are commented out that can be activated by uncommenting the skeleton and completing the implementation.

@aprokop
Copy link
Collaborator

aprokop commented Dec 2, 2017

We can start uncommenting tests.

@aprokop aprokop added this to the FY18Q1 milestone Dec 17, 2017
kruger added a commit to Tech-XCorp/ForTrilinos that referenced this issue Sep 18, 2019
This increases the coverage of ForTrilinos and addresses
primarily Issues trilinos#135 (CrsGraph), but also
Issues trilinos#121 (MultiVector) and trilinos#120 (CrsMatrix)
as well as improving coverage in tpetra and interface.

The method is to create *Unit-style tests that are as small
as possible while providing a thorough test.  To that end,
"helper files" (e.g., test_tpetra_crsgraph_helper.F90 or
test_tpetra_crsmatrix_helper.F90) were created to provide
standard matrices, graphs, maps, etc.  for testing.  The
matrix helper file is also used by the interface routines to
solve linear systems or find eigenvalues.

Other development goals:
- the pre-existing "fat tests" are maintained for useful examples
- tests must run in serial or parallel from command-line (ctest
  only tests one or the other)
- tests must be clean (no RCP errors) when running from command-line
- methods for crsgraph and crsmatrix try to show when fillComplete
  is needed for a given call.  Helper files do not fillComplete

Miscellaneous documentation changes are also included, and
build system changes were required.

Co-authored-by: Andrey Prokopenko <[email protected]>
Co-authored-by: Michel de Messiere <[email protected]>
Co-authored-by: Jared Popelar <[email protected]>
kruger added a commit to Tech-XCorp/ForTrilinos that referenced this issue Sep 18, 2019
This increases the coverage of ForTrilinos and addresses
primarily Issues trilinos#135 (CrsGraph), but also
Issues trilinos#121 (MultiVector) and trilinos#120 (CrsMatrix)
as well as improving coverage in tpetra and interface.

The method is to create *Unit-style tests that are as small
as possible while providing a thorough test.  To that end,
"helper files" (e.g., test_tpetra_crsgraph_helper.F90 or
test_tpetra_crsmatrix_helper.F90) were created to provide
standard matrices, graphs, maps, etc.  for testing.  The
matrix helper file is also used by the interface routines to
solve linear systems or find eigenvalues.

Other development goals:
- the pre-existing "fat tests" are maintained for useful examples
- tests must run in serial or parallel from command-line (ctest
  only tests one or the other)
- tests must be clean (no RCP errors) when running from command-line
- methods for crsgraph and crsmatrix try to show when fillComplete
  is needed for a given call.  Helper files do not fillComplete

Miscellaneous documentation changes are also included, and
build system changes were required.

Co-authored-by: Andrey Prokopenko <[email protected]>
Co-authored-by: Michel de Messiere <[email protected]>
Co-authored-by: Jared Popelar <[email protected]>
kruger added a commit to Tech-XCorp/ForTrilinos that referenced this issue Sep 18, 2019
This increases the coverage of ForTrilinos and addresses
primarily Issues trilinos#135 (CrsGraph), but also
Issues trilinos#121 (MultiVector) and trilinos#120 (CrsMatrix)
as well as improving coverage in tpetra and interface.

The method is to create *Unit-style tests that are as small
as possible while providing a thorough test.  To that end,
"helper files" (e.g., test_tpetra_crsgraph_helper.F90 or
test_tpetra_crsmatrix_helper.F90) were created to provide
standard matrices, graphs, maps, etc.  for testing.  The
matrix helper file is also used by the interface routines to
solve linear systems or find eigenvalues.

Other development goals:
- the pre-existing "fat tests" are maintained for useful examples
- tests must run in serial or parallel from command-line (ctest
  only tests one or the other)
- tests must be clean (no RCP errors) when running from command-line
- methods for crsgraph and crsmatrix try to show when fillComplete
  is needed for a given call.  Helper files do not fillComplete

Miscellaneous documentation changes are also included, and
build system changes were required.

Co-authored-by: Andrey Prokopenko <[email protected]>
Co-authored-by: Michel de Messiere <[email protected]>
Co-authored-by: Jared Popelar <[email protected]>
kruger added a commit to Tech-XCorp/ForTrilinos that referenced this issue Sep 19, 2019
This increases the coverage of ForTrilinos and addresses
primarily Issues trilinos#135 (CrsGraph), but also
Issues trilinos#121 (MultiVector) and trilinos#120 (CrsMatrix)
as well as improving coverage in tpetra and interface.

The method is to create *Unit-style tests that are as small
as possible while providing a thorough test.  To that end,
"helper files" (e.g., test_tpetra_crsgraph_helper.F90 or
test_tpetra_crsmatrix_helper.F90) were created to provide
standard matrices, graphs, maps, etc.  for testing.  The
matrix helper file is also used by the interface routines to
solve linear systems or find eigenvalues.

Other development goals:
- the pre-existing "fat tests" are maintained for useful examples
- tests must run in serial or parallel from command-line (ctest
  only tests one or the other)
- tests must be clean (no RCP errors) when running from command-line
- methods for crsgraph and crsmatrix try to show when fillComplete
  is needed for a given call.  Helper files do not fillComplete

Miscellaneous documentation changes are also included, and
build system changes were required.

Co-authored-by: Andrey Prokopenko <[email protected]>
Co-authored-by: Michel de Messiere <[email protected]>
Co-authored-by: Jared Popelar <[email protected]>
aprokop added a commit to Tech-XCorp/ForTrilinos that referenced this issue Sep 19, 2019
This increases the coverage of ForTrilinos and addresses
primarily Issues trilinos#135 (CrsGraph), but also
Issues trilinos#121 (MultiVector) and trilinos#120 (CrsMatrix)
as well as improving coverage in tpetra and interface.

The method is to create *Unit-style tests that are as small
as possible while providing a thorough test.  To that end,
"helper files" (e.g., test_tpetra_crsgraph_helper.F90 or
test_tpetra_crsmatrix_helper.F90) were created to provide
standard matrices, graphs, maps, etc.  for testing.  The
matrix helper file is also used by the interface routines to
solve linear systems or find eigenvalues.

Other development goals:
- the pre-existing "fat tests" are maintained for useful examples
- tests must run in serial or parallel from command-line (ctest
  only tests one or the other)
- tests must be clean (no RCP errors) when running from command-line
- methods for crsgraph and crsmatrix try to show when fillComplete
  is needed for a given call.  Helper files do not fillComplete

Miscellaneous documentation changes are also included, and
build system changes were required.

Co-authored-by: Andrey Prokopenko <[email protected]>
Co-authored-by: Michel de Messiere <[email protected]>
Co-authored-by: Jared Popelar <[email protected]>
aprokop added a commit that referenced this issue Sep 19, 2019
Improve test coverage of ForTrilinos

This increases the coverage of ForTrilinos and addresses
primarily Issues #135 (CrsGraph), but also
Issues #121 (MultiVector) and #120 (CrsMatrix)
as well as improving coverage in tpetra and interface.

The method is to create *Unit-style tests that are as small
as possible while providing a thorough test.  To that end,
"helper files" (e.g., test_tpetra_crsgraph_helper.F90 or
test_tpetra_crsmatrix_helper.F90) were created to provide
standard matrices, graphs, maps, etc.  for testing.  The
matrix helper file is also used by the interface routines to
solve linear systems or find eigenvalues.

Other development goals:
- the pre-existing "fat tests" are maintained for useful examples
- tests must run in serial or parallel from command-line (ctest
  only tests one or the other)
- tests must be clean (no RCP errors) when running from command-line
- methods for crsgraph and crsmatrix try to show when fillComplete
  is needed for a given call.  Helper files do not fillComplete

Miscellaneous documentation changes are also included, and
build system changes were required.

Co-authored-by: Andrey Prokopenko <[email protected]>
Co-authored-by: Michel de Messiere <[email protected]>
Co-authored-by: Jared Popelar <[email protected]>
@aprokop
Copy link
Collaborator

aprokop commented Sep 20, 2019

Fixed by #262.

@aprokop aprokop closed this as completed Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants