Skip to content

Apply workaround for antlr/antlr4#4901 #27341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2025
Merged

Apply workaround for antlr/antlr4#4901 #27341

merged 1 commit into from
Nov 17, 2025
+11 −0

Conversation

@wendigo
Copy link
Contributor

@wendigo wendigo commented Nov 17, 2025 •
edited by findepi
Loading

Description

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text:

PF: this should not be mentioned in release notes IMO

## General
* Workaround query corruption issue that happens in a highly concurrent scenario on certain ARM processors ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Nov 17, 2025
@wendigo wendigo requested a review from findepi November 17, 2025 17:54
@findepi
Copy link
Member

findepi commented Nov 17, 2025

cc @lukasz-stec @martint

martint
martint approved these changes Nov 17, 2025
View reviewed changes
Copy link
Member

@martint martint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, fill in the PR description.

@wendigo wendigo merged commit 8bec3ea into trinodb:master Nov 17, 2025
98 of 99 checks passed
@github-actions github-actions bot added this to the 479 milestone Nov 17, 2025
@findepi findepi added the no-release-notes This pull request does not require release notes entry label Nov 17, 2025
@findepi
Copy link
Member

findepi commented Nov 17, 2025

re: RNs
this should not be mentioned in release notes IMO.

we don't have evidence of this affecting trino. we merged this change to be on the safe side.
based on the knowledge of the bug, i actually did try to find places where trino could work incorrectly, and did not find any actual candidate place.

@chenjian2664 chenjian2664 mentioned this pull request Nov 18, 2025
Open
@chenjian2664
Copy link
Contributor

chenjian2664 commented Nov 24, 2025

@findepi Thanks, will add a ❌ for this entry in #27153

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martint martint martint approved these changes

@findepi findepi findepi approved these changes

Assignees

No one assigned

Labels

cla-signed no-release-notes This pull request does not require release notes entry

Milestone

479

Development

Successfully merging this pull request may close these issues.

4 participants

@wendigo @findepi @chenjian2664 @martint