Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export only ES modules #89

Open
pago opened this issue Jan 13, 2019 · 1 comment
Open

Export only ES modules #89

pago opened this issue Jan 13, 2019 · 1 comment
Labels
good first issue
Milestone
2.0.0

Comments

@pago
Copy link
Contributor

pago commented Jan 13, 2019

By now ES modules are a well supported standard and can be used by the browser as well as Webpack, Rollup and other bundlers. Melody itself doesn't benefit from being exported as CJS.

We can simplify our tooling and avoid mistakes for our users by switching to ES modules and ignoring the CJS use case.

This is a breaking change.
@pago pago added this to the 2.0.0 milestone Jan 13, 2019
@ayusharma
Copy link
Collaborator

I think we can also drop Node 6 support as it is going to END OF LIFE in April 2019.

ayusharma added a commit to ayusharma/melody that referenced this issue Mar 2, 2019
@ayusharma
feat: export only es modules (trivago#89)
44f1ac2
ayusharma added a commit to ayusharma/melody that referenced this issue Mar 3, 2019
@ayusharma
feat: export only es modules (trivago#89)
68c064d
ayusharma added a commit to ayusharma/melody that referenced this issue Mar 3, 2019
@ayusharma
feat: export only es modules (trivago#89)
9661de7
@ayusharma ayusharma mentioned this issue Mar 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@pago @ayusharma