Merge pull request ethereum#11657 from ethereum/fixParserDestructor

chriseth · web-flow · commit 57d32ca252ce · 2021-07-13T17:59:04.000+02:00
ParserBase has virtual functions but did not have a virtual dtor.
diff --git a/liblangutil/ParserBase.h b/liblangutil/ParserBase.h
@@ -47,6 +47,8 @@ class ParserBase
 		m_parserErrorRecovery = _parserErrorRecovery;
 	}
 
+	virtual ~ParserBase() = default;
+
 	std::shared_ptr<CharStream> source() const { return m_scanner->charStream(); }
 
 protected:

Original file line number	Diff line number	Diff line change
`@@ -47,6 +47,8 @@ class ParserBase`
`47`	`47`	`m_parserErrorRecovery = _parserErrorRecovery;`
`48`	`48`	`}`
`49`	`49`
	`50`	`+ virtual ~ParserBase() = default;`
	`51`	`+`
`50`	`52`	`std::shared_ptr<CharStream> source() const { return m_scanner->charStream(); }`
`51`	`53`
`52`	`54`	`protected:`