Skip to content

Commit aa7df72

Browse files
authored
[workflows] Fix broken uploads (#708)
`cargo llvm-cov --no-report nextest` was running the tests and would finish the `run_tests` action before we'd generated the xml. Merge that logic together and make sure to return the original exit code when done.
1 parent 9b92290 commit aa7df72

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

.github/actions/run_tests/action.yaml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,16 +29,16 @@ runs:
2929
- name: Collect coverage data (including doctests)
3030
shell: bash
3131
run: |
32-
cargo llvm-cov --no-report nextest
32+
set +e
33+
cargo llvm-cov --no-report nextest --features=bindings --workspace ${{ contains(inputs.target, 'musl') && '--exclude context-js --exclude context-py --exclude context_ruby' || '' }} --profile=ci
34+
exitcode="$?"
3335
cargo llvm-cov --no-report --doc
3436
cargo llvm-cov report --doctests --lcov --output-path lcov.info
35-
36-
- name: Run tests
37-
shell: bash
38-
run: cargo nextest run --features=bindings --workspace ${{ contains(inputs.target, 'musl') && '--exclude context-js --exclude context-py --exclude context_ruby' || '' }} --profile=ci
37+
exit "$exitcode"
3938
4039
- name: Upload coverage reports to Codecov
4140
uses: codecov/codecov-action@v5
41+
if: always()
4242
with:
4343
token: ${{ inputs.codecov-token }}
4444
slug: trunk-io/analytics-cli

0 commit comments

Comments
 (0)