Skip to content

Conversation

@tschm
Copy link
Owner

@tschm tschm commented Dec 8, 2025

This PR syncs the template from:
tschm/.config-templates @ main

Summary by CodeRabbit

  • Chores
    • Improved Python version parsing in the release workflow for enhanced error handling and reliability during automated releases.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 8, 2025

Walkthrough

Modified the Python version input in the GitHub Actions release workflow to parse the version string as JSON using fromJSON() instead of consuming the raw output directly. This changes how the value is processed from prior workflow steps.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow Configuration
.github/workflows/release.yml
Modified the "Set up Python" step to wrap outputs.python-version with fromJSON(), altering version string parsing from raw output to JSON-parsed format

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Verify that the upstream script output is valid JSON-encoded before this step consumes it
  • Check if this change affects error handling for malformed or non-JSON version strings
  • Confirm the downstream "Set up Python" action accepts the parsed format correctly

Poem

🐰 A version wrapped in JSON's gentle glow,
No longer raw, but parsed just so,
From script output to structured grace,
The workflow flows at faster pace! 🚀

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: a template synchronization from tschm/.config-templates@main, which aligns with the single-line workflow adjustment in .github/workflows/release.yml.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch template-updates

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2940fc3 and 47338ba.

📒 Files selected for processing (1)
  • .github/workflows/release.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Run notebook book/marimo/demo.py
  • GitHub Check: Run notebook book/marimo/demo.py
🔇 Additional comments (1)
.github/workflows/release.yml (1)

313-321: The fromJSON() wrapper is correct and necessary.

The .github/workflows/scripts/version_max.py script explicitly outputs JSON-encoded strings using json.dumps(). For example, it prints "3.13" (a JSON string with quotes), not plain text like 3.13. The fromJSON() call correctly parses this JSON output to extract the actual version string 3.13, which is required for the python-version input. Without fromJSON(), the workflow would receive the literal string "3.13" (including quotes), causing the version setup to fail. The change is correct and properly handles the script's output format.

Likely an incorrect or invalid review comment.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tschm tschm merged commit 0af96e1 into main Dec 8, 2025
26 checks passed
@tschm tschm deleted the template-updates branch December 8, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants