Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure capacitance is properly turned into a float by transforming it's precision #118

Closed
seveibar opened this issue Jan 7, 2025 · 4 comments · Fixed by #119
Closed

Comments

@seveibar
Copy link
Contributor

seveibar commented Jan 7, 2025

https://stackoverflow.com/a/3644302

Sometimes capacitance comes out like 0.009999999999 when it's supposed to be 0.001, this is because of some javascript rounding issues, but we can fix it with the precision transform described in the above issue.

In order to show you solved this issue, you'd need to come up with a reproduction. I believe trying to parse capacitors with 1uF, 10uF, 100uF, 1pF, 10pF etc. would eventually reproduce the issue

/bounty $3

Copy link

algora-pbc bot commented Jan 7, 2025

💎 $3 bounty • tscircuit

Steps to solve:

  1. Start working: Comment /attempt #118 with your implementation plan
  2. Submit work: Create a pull request including /claim #118 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to tscircuit/circuit-json!

Add a bountyShare on socials

Attempt Started (GMT+0) Solution
🟢 @Anshgrover23 Jan 7, 2025, 9:19:14 AM #119

@Anshgrover23
Copy link
Contributor

Anshgrover23 commented Jan 7, 2025

/attempt #118

Algora profile Completed bounties Tech Active attempts Options
@Anshgrover23    36 tscircuit bounties
+ 3 bounties from 3 projects
TypeScript, JavaScript,
Go & more
﹟2
Cancel attempt

Copy link

algora-pbc bot commented Jan 7, 2025

💡 @Anshgrover23 submitted a pull request that claims the bounty. You can visit your bounty board to reward.

Copy link

algora-pbc bot commented Jan 7, 2025

🎉🎈 @Anshgrover23 has been awarded $3! 🎈🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants