Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cadModel positionOffset axis are not calculated correctly when importing from jlcpcb #123

Open
Abse2001 opened this issue Dec 4, 2024 · 5 comments · May be fixed by #152
Open

cadModel positionOffset axis are not calculated correctly when importing from jlcpcb #123

Abse2001 opened this issue Dec 4, 2024 · 5 comments · May be fixed by #152
Labels
💎 Bounty

Comments

@Abse2001
Copy link

Abse2001 commented Dec 4, 2024 •
edited
Loading

It should match the footprint (to align with the plated holes X , Y axis) and the board (to not go inside the board Z axis)
repro try to import something from jlcpcb in snippet
snippet.ts
Image
Image
Image
Image
@Abse2001 Abse2001 changed the title cadModel axis are not calculated correctly to match the footprint and the board cadModel positionOffset axis are not calculated correctly to match the footprint and the board Dec 4, 2024
@Abse2001 Abse2001 changed the title cadModel positionOffset axis are not calculated correctly to match the footprint and the board cadModel positionOffset axis are not calculated correctly to match the footprint (to align with the plated holes X Y axis) and the board (to not go inside the board Z axis) Dec 4, 2024
@Abse2001 Abse2001 changed the title cadModel positionOffset axis are not calculated correctly to match the footprint (to align with the plated holes X Y axis) and the board (to not go inside the board Z axis) cadModel positionOffset axis are not calculated correctly Dec 4, 2024
@Abse2001 Abse2001 changed the title cadModel positionOffset axis are not calculated correctly cadModel positionOffset axis are not calculated correctly when importing from jlcpcb Dec 4, 2024
@seveibar
Copy link
Contributor

seveibar commented Dec 5, 2024

/bounty $30

@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Dec 5, 2024 •
edited
Loading

💎 $30 bounty • tscircuit

Steps to solve:

  1. Start working: Comment /attempt #123 with your implementation plan
  2. Submit work: Create a pull request including /claim #123 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to tscircuit/easyeda-converter!

Add a bounty • Share on socials

Attempt Started (GMT+0) Solution
🟢 @techmannih #152

@coder-pink
Copy link

@Abse2001 I'll work on this. Can you assign this to me

@Abse2001
Copy link
Author

Abse2001 commented Dec 5, 2024

@coder-pink we actually don't assign issues it's who fix it first get's it.
Good Luck

@techmannih techmannih linked a pull request Jan 24, 2025 that will close this issue
Draft
@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Jan 24, 2025

💡 @techmannih submitted a pull request that claims the bounty. You can visit your bounty board to reward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💎 Bounty
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correct axis calculation for positionOffset When Importing from JLCPCB techmannih/easyeda-converter
3 participants
@seveibar @Abse2001 @coder-pink