Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add SOT-6 #169

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add SOT-6 #169

wants to merge 1 commit into from

Conversation

kom-senapati
Copy link
Contributor

Closes #168

seveibar
seveibar approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks fine, i'm not sure about the dimensions, you should get one other approval before merge!

Anshgrover23
Anshgrover23 requested changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@Anshgrover23 Anshgrover23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kom-senapati can u show the reference datasheet like where u have taken the dimensions or any screenshot or something

@kom-senapati
Copy link
Contributor Author

image

techmannih
techmannih suggested changes Feb 13, 2025
View reviewed changes
Copy link
Collaborator

@techmannih techmannih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kom-senapati add function in footpinter

tests/sot6.test.ts
import { fp } from "../src/footprinter"

test("sot6", () => {
const soup = fp.string("sot6").circuitJson()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use circuitJson instead of soup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techmannih techmannih techmannih requested changes

@Anshgrover23 Anshgrover23 Anshgrover23 requested changes

@seveibar seveibar seveibar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement SOT-6
4 participants
@kom-senapati @seveibar @techmannih @Anshgrover23