Clear/Remove ToDos from code

Author: haenno

doku/literatur.bib

@@ -1,7 +1,3 @@
-%TODO: 
-%Seitenzahlen bei Herausgeberwerken/Buchteilen hinschreiben
-%DOI links pflegen
-
 
 @misc{heise-django-2011,
   author = {{heise online, Matthias Wessendorf}},
@@ -19,94 +15,3 @@ @book{scheurer
   isbn={9783825287061}
 }
 
-
-@incollection{kremer2005werkstatt,
-  title={Werkstatt-Wettbewerb Quartier},
-  author={Kremer-Prei{\ss}, Ursula and Stolarz, Holger},
-  booktitle={Dokumentation der ausgezeichneten Beitr{\"a}ge},
-  year={2005},
-  editor={Bertelsmann Stiftung, Gütersloh und Kuratorium Deutsche Altershilfe (KDA), Köln}
-}
-
-@incollection{schnur2014quartiersforschung,
-  %doi={10.1007/978-3-531-19963-4},
-  booktitle={Quartiersforschung: Zwischen Theorie und Praxis},
-  author={Schnur, Olaf},
-  year={2014},
-  pages={21-56},
-  publisher={Springer VS},
-  location={Wiesbaden},
-  editor={Schnur, Olaf and Drilling, Matthias and Gebhardt, Dirk},
-  title={Quartiersforschung im Überblick: Konzepte, Definitionen und aktuelle Perspektiven}
-}
-
-@incollection{brauer2011einfuhrung,
-  title={Einf{\"u}hrung in die Immobilienwirtschaft},
-  author={Brauer, Kerry-U},
-  booktitle={Grundlagen der Immobilienwirtschaft},
-  year={2011},
-  pages={1-52},
-  editor = {Brauer, Kerry-U},
-  publisher={Springer Gabler},
-  location={Wiesbaden}
-}
-
-@book{wirtschaftsfaktorimmo,
-  title={Wirtschaftsfaktor Immobilien 2017},
-  author={Just, Tobias and Voigtl{\"a}nder, Michael and Eisfeld, Rupert and Henger, Ralph and Hesse, Markus and Toschka, Alexandra},
-  year={2017},
-  publisher={IREBS International Real Estate Business School, Universit{\"a}t Regensburg}
-}
-
-@incollection{immotrans,
-  title={Transformation der Immobilienwirtschaft: Eine empirische Studie deutscher immobilienwirtschaftlicher Akteure},
-  author={Pfn{\"u}r, Andreas and Wagner, Benjamin},
-  year={2018},
-  booktitle={Arbeitspapiere zur immobilienwirtschaftlichen Forschung und Praxis},
-  editor = {Pfn{\"u}r, Andreas},
-  volume = {37} 
-}
-
-@book{eichhorn2016,
-  title={Das Prinzip Wirtschaftlichkeit},
-  author={Eichhorn, Peter and Merk, Joachim},
-  year={2016},
-  edition={4},
-  publisher={Springer Gabler},
-  location={Wiesbaden}
-  %doi={10.1007/978-3-658-07830-0}
-}
-
-@misc{rft-poc,
-  author = {{Rat für Forschung und Technologieentwicklung}},
-  title  = {{Empfehlung zu einer optimierten Proof-of-Concept-Unterstützung im Wissenstransfers}},
-  url    = {https://www.rat-fte.at/files/rat-fte-pdf/einzelempfehlungen/2013/131203_Empfehlung_Proof%20of%20Concept.pdf},
-  urldate = {2020-06-01},
-  year   = {2013},
-}
-
-@misc{kiwi,
-  author = {{KIWI.KI GmbH}},
-  title  = {{Die KIWI Story}},
-  url    = {https://kiwi.ki/unternehmen/},
-  urldate = {2020-06-06},
-  year   = {2020},
-}
-
-@article{zia,
-  title={Einsatz digitaler Technologien in der Immobilienwirtschaft},
-  author={Rodeck, Martin and Schulz-Wulkow, Christian and Bäß, Thilo and Kremer, Gerald  and Dr. Scheidecker, Lars},
-  journal={Studie vom Zentralen Immobilien Ausschuss (ZIA) und Ernst \& Young Real Estate GmbH (EY)},
-  year={2016}
-}
-
-
-@article{ct-3-2004,
-    author ={Wester, J{\"o}rg},
-    title = {{Microsoft gibt Smart Displays auf}},
-    journal = {{c't-Magazin}},
-    volume = {2004},
-    number = {3},
-    pages = {24},
-    year = {2004}
-}

doku/thesis_main.tex

@@ -54,8 +54,6 @@
 \usepackage[hang, multiple]{footmisc} % Mehrere Fussnoten nacheinander mit Komma separiert
 \setlength{\footnotemargin}{1em}
 
-%\usepackage{todonotes} % todo Aufgaben als Kommentare verfassen für verschiedene Editoren
-
 \usepackage{epstopdf} %Pakete für Tabellen
 \usepackage{nicefrac} % Brüche
 \usepackage{multirow}

rpg/rjh_rpg/consumer_game.py

@@ -113,8 +113,7 @@ async def receive(self, text_data):
                 self.my_user_char = await db_get_user_char_from_user_id(self.game_id, self.request_user_id)
 
 
-            # (TODO!) update timestamps, delete old entrys
-            # check timestamps, delete old and zombie  entrys
+            # (OPT/LATER/BONUS) update timestamps, delete old entrys, check timestamps, delete old and zombie  entrys
 
             self.mycounter = self.mycounter + 1
 
@@ -142,7 +141,7 @@ async def receive(self, text_data):
             # this part sadly does not work correctly. problem here is that with multiple 
             # clients/players, the rounds are driven at the same time. solution should be
             # a token -- but this token also need to be synced, which brings new promblems.
-            # (TODO!) get expert help on that.
+            # (OPT/LATER/BONUS) get expert help on that.
 
             # self.round_state_token_is_mine = False
             # if await db_get_is_round_state_locked(self.game_id) == False:            
@@ -253,7 +252,6 @@ async def receive(self, text_data):
 
                 elif round_state == 100:
 
-                    # (TODO!) Implement selection based on aggro-table instand of random char
                     char_to_hit = await db_get_random_alive_user_char_in_games_id(self.game_id) 
 
                     if not char_to_hit: # failsave in case no player is alive

rpg/rjh_rpg/consumer_game_tools.py

@@ -111,7 +111,7 @@ def db_set_user_char_to_dead(user_char_in_games_id):
 @database_sync_to_async
 def db_give_dmg_to_user_char(user_char_in_games_id, ap_to_deliver):
     last_hp = UserCharInGames.objects.get(id=user_char_in_games_id).current_hp
-    ap_to_deliver = random.randint(int(ap_to_deliver * rpg_get_config("dmg_min")), int(ap_to_deliver * rpg_get_config("dmg_max"))) # (TODO!) Maybe later replace with dice
+    ap_to_deliver = random.randint(int(ap_to_deliver * rpg_get_config("dmg_min")), int(ap_to_deliver * rpg_get_config("dmg_max"))) 
     new_hp = last_hp - int(ap_to_deliver)
     if new_hp < 0:
         new_hp = 0
@@ -204,7 +204,7 @@ def db_get_user_char_current_hp(user_char_in_games_id):
 @database_sync_to_async
 def db_give_dmg_to_enemy(game_id, ap_to_deliver):
     last_hp = Games.objects.get(id=game_id).enemy_current_hp
-    ap_to_deliver = random.randint(int(ap_to_deliver * rpg_get_config("dmg_min")), int(ap_to_deliver * rpg_get_config("dmg_max")))  # (TODO!) Maybe later replace with dice
+    ap_to_deliver = random.randint(int(ap_to_deliver * rpg_get_config("dmg_min")), int(ap_to_deliver * rpg_get_config("dmg_max"))) 
     new_hp = last_hp - int(ap_to_deliver)
     if new_hp < 0:
         new_hp = 0

rpg/rjh_rpg/consumer_lobby.py

@@ -103,12 +103,9 @@ async def msg_group_send_content(self, event):
                 slot_template = slot_template.replace('**js_button_function**','free_the_slot')
                 slot_template = slot_template.replace('**button_text**','Platz freigeben')
 
-                # (TODO!) every user gets the same html string, so this logic does not work in this way. 
-                # maybe with JS an local check if the char_id fits the button
-                # if str(user_char_name) == str(char_name): # disable button not here, maybe on countdown
-                #    slot_template = slot_template.replace('**button_disabled**','**button_disabled_for_lvl2**')
-                # else: # disable button here now - because first you need to free the taken slot
-                #    slot_template = slot_template.replace('**button_disabled**','disabled')
+                # (OPT/LATER/BONUS) every user gets the same html string. set a button to disabled, 
+                # could be solved in the client with JS
+                
                 slot_template = slot_template.replace('**button_disabled**','**button_disabled_for_lvl2**')
 
             else: # slot is free
@@ -205,9 +202,6 @@ async def receive(self, text_data):
         char_id = text_data_json['char_id']
 
         if message == 'heartbeat':
-            # (TODO!) update timestamps, delete old entrys
-            # check timestamps, delete old and zombie  entrys
-            
             try:
                 heartbeat_char_id = text_data_json['char_id']
                 await rpg_websocket_user_char_chat_heartbeat(heartbeat_char_id)

rpg/rjh_rpg/consumers.py

@@ -87,7 +87,6 @@ async def chatroom_message(self, event):
 
     @database_sync_to_async     
     def db_get_list_chars_in_chat(self):
-        # (TODO!) Delete users with to old datetime 'lastaction'
         list_of_chars_in_chat = GameState.objects.filter(place=self.room_name).order_by('char')
         current_datetime = int(datetime.now().strftime('%s'))
         chat_timeout = rpg_get_config('chat_timeout')

rpg/rjh_rpg/models.py

@@ -48,7 +48,7 @@ class Char_Class(models.TextChoices):
     xp_to_spend =  models.IntegerField(default=0)
 
 
-    def __str__(self): # (TODO!) this maybe the cause of many problems... why do we need this? would it be better w/o? to fetch id's...
+    def __str__(self):
         return self.name
 
 
@@ -74,7 +74,7 @@ def __str__(self):
 class LobbySlots(models.Model):
     user_char_id = models.OneToOneField(UserChar, on_delete=models.CASCADE, unique=True)
     game_scene_id = models.ForeignKey(GameScenes, on_delete=models.CASCADE) # also known as scene_id
-    slot_id = models.IntegerField(null=True, blank=True) # also known as scene_id    (TODO!) install as a required field w/o null and blank   
+    slot_id = models.IntegerField(null=True, blank=True) # also known as scene_id   
     datetime_slot_taken = models.DateTimeField(default=datetime.now) 
     datetime_locked_in = models.DateTimeField(null=True, blank=True)    
 

rpg/rjh_rpg/views.py

@@ -51,7 +51,7 @@ def login(request):
             user = auth.authenticate(username=request.POST['username'],password = request.POST['password'])
             if user is not None:
                 auth.login(request,user)
-                # (TODO!) should we delete gamesessions here?
+                # (OPT/LATER/BONUS) delete gamesessions here
                 return redirect('home')
             else:
                 return render (request,'login.html', {'error':'Benutzername oder Passwort falsch!'})