fix(detection): improve breaking change string detection

and the tests

Signed-off-by: Charlike Mike Reagent <[email protected]>

Author: Charlike Mike Reagent

src/index.js

@@ -82,8 +82,8 @@ function isBreakingChange ({ subject, body, footer }) {
   body = body || ''
   footer = footer || ''
 
-  const re = 'BREAKING CHANGE:'
-  return subject.includes(re) || body.includes(re) || footer.includes(re)
+  const re = /^BREAKING(?: CHANGES?)?:/
+  return re.test(subject) || re.test(body) || re.test(footer)
 }
 
 /**

test/index.js

@@ -4,7 +4,7 @@
  */
 
 const test = require('mukla')
-const { parse } = require('../src/index.js')
+const { parse, plugins } = require('../src/index.js')
 
 test('should .parse method to work correctly', (done) => {
   const commitMsg1 = `feat(ng-list): Allow custom separator
@@ -14,7 +14,7 @@ BREAKING CHANGE: some breaking change.
 Thanks @foobar
 `
 
-  const commit = parse(commitMsg1)
+  const commit = parse(commitMsg1, plugins)
   // => { type: 'feat',
   //   scope: 'ng-list',
   //   subject: 'Allow custom separator',
@@ -32,10 +32,22 @@ Thanks @foobar
     commit.footer,
     'BREAKING CHANGE: some breaking change.\nThanks @foobar'
   )
+  test.strictEqual(commit.increment, 'major')
   done()
 })
 
 test('should .parse throw for invalid commit convention message', (done) => {
   test.throws(() => parse('foo bar baz'), /invalid commit message/)
   done()
 })
+
+test('do not treat BREAKING CHANGE as major when not at the beginning', (done) => {
+  const commitMessage = 'fix(abc): foo bar BREAKING CHANGE here is not valid'
+  const commit = parse(commitMessage, plugins)
+
+  test.strictEqual(commit.type, 'fix')
+  test.strictEqual(commit.scope, 'abc')
+  test.strictEqual(commit.subject, 'foo bar BREAKING CHANGE here is not valid')
+  test.strictEqual(commit.increment, 'patch')
+  done()
+})