Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong posts displayed in timeline #4588

Open
Joshix-1 opened this issue Jul 28, 2024 · 6 comments
Open

Wrong posts displayed in timeline #4588

Joshix-1 opened this issue Jul 28, 2024 · 6 comments
Labels
bug

Comments

@Joshix-1
Copy link

Detailed description

Sometimes shortly after loading more posts into the timeline near the top of it, the posts that are shown are wrong. They were near the top before but should've been replaced by new ones and when I click on them I get to different posts. This happened multiple times.

screen-20240724-225511.mp4

Steps to reproduce the problem

  1. Look through timeline
  2. Load more posts by swiping down on top
  3. Sometimes when I click on a post it links to a different than the one displayed
    ...

Debug information

Tusky 26.0

Device:

Gigaset E940-2878-03
Android version: 13
SDK version: 33

Account:

@[email protected]
Version: 4.2.10+fosspride

Reading order: Newest first
@Joshix-1 Joshix-1 added the bug label Jul 28, 2024
@connyduck
Copy link
Collaborator

Are you logged in with multiple accounts, and if yes could this be the same bug where Tusky confuses posts of different accounts?

@Joshix-1
Copy link
Author

i'm logged in with multiple accounts (mine & the bot account on my instance), but the other account doesn't follow the accounts in the video

@Joshix-1
Copy link
Author

I think it happens mostly when I have a bad internet connection, but I'm not sure

@connyduck connyduck mentioned this issue Aug 6, 2024
Merged
connyduck added a commit that referenced this issue Aug 14, 2024
@connyduck
prevent mixup of account timelines (#4599)
c7387c7 
This does 2 things:

- Removes `AccountSwitchInterceptor`, the main culprit for the bug. APIs
can no longer change their base url after they have been created. As a
result they are not Singletons anymore.
- Additionally, I refactored how MainActivity handles Intents to make it
less likely to have multiple instances of it active.

Here is how I could reliably reproduce the bug:

- Be logged in with account A and B
- Write a post with account A, cancel it before it sends (go into flight
mode for that)
- Switch to account B
- Open the "this post failed to send" notification from account A,
drafts will open
- Go back. You are in the MainActivity of account A, everything seems
fine.
- Go back again. You are in the old, now broken MainActivity of account
B. It uses the database of account B but the network of account A.
Refreshing will show posts from A.

closes #4567 
closes #4554
closes #4402 
closes #4148
closes #2663
and possibly #4588
@Joshix-1
Copy link
Author

Joshix-1 commented Sep 4, 2024

Happened again

https://cdn.masto.fosspride.de/media_attachments/files/113/079/509/370/019/895/original/279394c7354f150c.mp4

@connyduck
Copy link
Collaborator

Is this the same post, boosted by the same person, but with different timestamps in the timeline twice? Weird, but that might be a clie what is happening.

Do you remember what you did before the video starts?

@Joshix-1
Copy link
Author

Joshix-1 commented Sep 4, 2024 •
edited
Loading

Is this the same post, boosted by the same person, but with different timestamps in the timeline twice?

yes, but clicking on the top one leads to another post with the timestamp of one minute ago

Do you remember what you did before the video starts?

not really, i probably just refreshed the timeline to load more posts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@connyduck @Joshix-1