From fbdd63d98ceaf85f9b31c1dad60cd0b9e4d75b38 Mon Sep 17 00:00:00 2001
From: Conny Duck <git@connyduck.at>
Date: Thu, 12 Sep 2024 20:43:46 +0200
Subject: [PATCH 01/11] change background of notification filter popupwindow

---
 .../components/notifications/NotificationsFragment.kt      | 2 +-
 app/src/main/res/layout/notifications_filter.xml           | 7 +++++--
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/app/src/main/java/com/keylesspalace/tusky/components/notifications/NotificationsFragment.kt b/app/src/main/java/com/keylesspalace/tusky/components/notifications/NotificationsFragment.kt
index c2001422d7..089f66b628 100644
--- a/app/src/main/java/com/keylesspalace/tusky/components/notifications/NotificationsFragment.kt
+++ b/app/src/main/java/com/keylesspalace/tusky/components/notifications/NotificationsFragment.kt
@@ -433,7 +433,7 @@ class NotificationsFragment :
         }
 
         val adapter = ArrayAdapter(requireContext(), android.R.layout.simple_list_item_multiple_choice, notificationTypeList)
-        val window = PopupWindow(requireContext())
+        val window = PopupWindow(requireContext(), null, com.google.android.material.R.attr.listPopupWindowStyle)
         val menuBinding = NotificationsFilterBinding.inflate(LayoutInflater.from(requireContext()), binding.root as ViewGroup, false)
 
         menuBinding.buttonApply.setOnClickListener {
diff --git a/app/src/main/res/layout/notifications_filter.xml b/app/src/main/res/layout/notifications_filter.xml
index 20aa5f43b1..d9f182c626 100644
--- a/app/src/main/res/layout/notifications_filter.xml
+++ b/app/src/main/res/layout/notifications_filter.xml
@@ -1,13 +1,15 @@
 <?xml version="1.0" encoding="utf-8"?>
 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
-    android:orientation="vertical" android:layout_width="200dp"
+    android:layout_width="200dp"
     android:layout_height="wrap_content"
-    android:background="?android:attr/windowBackground">
+    android:orientation="vertical">
+
     <ListView
         android:id="@+id/listView"
         android:layout_width="match_parent"
         android:layout_height="0dp"
         android:layout_weight="1" />
+
     <Button
         android:id="@+id/buttonApply"
         style="@style/TuskyButton.TextButton"
@@ -16,4 +18,5 @@
         android:layout_weight="0"
         android:text="@string/filter_apply"
         android:textSize="?attr/status_text_medium" />
+
 </LinearLayout>

From 351da43f240434c02eee1d4024e68cf7d4bffe68 Mon Sep 17 00:00:00 2001
From: Conny Duck <git@connyduck.at>
Date: Thu, 12 Sep 2024 21:18:19 +0200
Subject: [PATCH 02/11] style date and time pickers

---
 app/src/main/res/values/styles.xml | 22 +++++++++++++++++++---
 1 file changed, 19 insertions(+), 3 deletions(-)

diff --git a/app/src/main/res/values/styles.xml b/app/src/main/res/values/styles.xml
index ae13980243..828688e95b 100644
--- a/app/src/main/res/values/styles.xml
+++ b/app/src/main/res/values/styles.xml
@@ -99,6 +99,9 @@
         <item name="alertDialogTheme">@style/TuskyDialogOverlay</item>
         <item name="dialogCornerRadius">16dp</item>
 
+        <item name="materialTimePickerTheme">@style/TuskyTimePickerOverlay</item>
+        <item name="materialCalendarTheme">@style/TuskyDatePickerOverlay</item>
+
         <item name="minTouchTargetSize">32dp</item> <!-- this affects RadioButton size -->
         <item name="elevationOverlayEnabled">false</item> <!-- disable the automatic tinting of surfaces with elevation in dark mode -->
 
@@ -143,9 +146,22 @@
     <style name="TuskyDialog" parent="@style/MaterialAlertDialog.Material3">
         <item name="shapeAppearance">@style/ShapeAppearance.Material3.Corner.Large</item>
         <item name="backgroundTint">@color/colorBackground</item>
-        <item name="buttonBarNeutralButtonStyle">@style/TuskyButton.TextButton</item>
-        <item name="buttonBarPositiveButtonStyle">@style/TuskyButton.TextButton</item>
-        <item name="buttonBarNegativeButtonStyle">@style/TuskyButton.TextButton</item>
+    </style>
+
+    <style name="TuskyTimePickerOverlay" parent="@style/ThemeOverlay.MaterialComponents.TimePicker">
+        <item name="materialTimePickerStyle">@style/TuskyTimePicker</item>
+    </style>
+    <style name="TuskyTimePicker" parent="@style/Widget.Material3.MaterialTimePicker">
+        <item name="shapeAppearance">@style/ShapeAppearance.Material3.Corner.Large</item>
+        <item name="backgroundTint">@color/colorBackground</item>
+    </style>
+
+    <style name="TuskyDatePickerOverlay" parent="@style/ThemeOverlay.MaterialComponents.MaterialCalendar">
+        <item name="materialCalendarStyle">@style/TuskyDatePicker</item>
+    </style>
+    <style name="TuskyDatePicker" parent="@style/Widget.Material3.MaterialCalendar">
+        <item name="shapeAppearance">@style/ShapeAppearance.Material3.Corner.Large</item>
+        <item name="backgroundTint">@color/colorBackground</item>
     </style>
 
     <style name="TuskyDialogFragmentStyle" parent="@style/ThemeOverlay.Material3.Dialog">

From 26685a7fffc196116f72e8e60023de1b7583ef0c Mon Sep 17 00:00:00 2001
From: Conny Duck <git@connyduck.at>
Date: Sun, 15 Sep 2024 16:42:11 +0200
Subject: [PATCH 03/11] change background color of help message for better
 contrast

---
 app/src/main/res/drawable/help_message_background.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/src/main/res/drawable/help_message_background.xml b/app/src/main/res/drawable/help_message_background.xml
index cb28b79870..abd6772306 100644
--- a/app/src/main/res/drawable/help_message_background.xml
+++ b/app/src/main/res/drawable/help_message_background.xml
@@ -7,7 +7,7 @@
         android:top="1dp">
 
         <shape android:shape="rectangle">
-            <solid android:color="?attr/colorBackgroundAccent"/>
+            <solid android:color="?attr/colorSurface"/>
             <stroke android:width="1dp" android:color="?attr/dividerColor"/>
         </shape>
     </item>

From 4fabe8d66de60d4db08f6686b05dd770ab2c53d9 Mon Sep 17 00:00:00 2001
From: Conny Duck <git@connyduck.at>
Date: Sun, 15 Sep 2024 17:04:02 +0200
Subject: [PATCH 04/11] use a card as help text background

---
 .../tusky/view/BackgroundMessageView.kt       |  6 ++--
 .../res/drawable/help_message_background.xml  | 14 --------
 .../res/layout/view_background_message.xml    | 34 ++++++++++++-------
 3 files changed, 25 insertions(+), 29 deletions(-)
 delete mode 100644 app/src/main/res/drawable/help_message_background.xml

diff --git a/app/src/main/java/com/keylesspalace/tusky/view/BackgroundMessageView.kt b/app/src/main/java/com/keylesspalace/tusky/view/BackgroundMessageView.kt
index c33533628f..56492853eb 100644
--- a/app/src/main/java/com/keylesspalace/tusky/view/BackgroundMessageView.kt
+++ b/app/src/main/java/com/keylesspalace/tusky/view/BackgroundMessageView.kt
@@ -15,6 +15,8 @@ import com.keylesspalace.tusky.databinding.ViewBackgroundMessageBinding
 import com.keylesspalace.tusky.util.addDrawables
 import com.keylesspalace.tusky.util.getDrawableRes
 import com.keylesspalace.tusky.util.getErrorString
+import com.keylesspalace.tusky.util.hide
+import com.keylesspalace.tusky.util.show
 import com.keylesspalace.tusky.util.visible
 
 /**
@@ -61,7 +63,7 @@ class BackgroundMessageView @JvmOverloads constructor(
         binding.imageView.setImageResource(imageRes)
         binding.button.setOnClickListener(clickListener)
         binding.button.visible(clickListener != null)
-        binding.helpText.visible(false)
+        binding.helpTextCard.hide()
     }
 
     fun showHelp(@StringRes helpRes: Int) {
@@ -72,6 +74,6 @@ class BackgroundMessageView @JvmOverloads constructor(
 
         binding.helpText.setText(textWithDrawables, TextView.BufferType.SPANNABLE)
 
-        binding.helpText.visible(true)
+        binding.helpTextCard.show()
     }
 }
diff --git a/app/src/main/res/drawable/help_message_background.xml b/app/src/main/res/drawable/help_message_background.xml
deleted file mode 100644
index abd6772306..0000000000
--- a/app/src/main/res/drawable/help_message_background.xml
+++ /dev/null
@@ -1,14 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<layer-list xmlns:android="http://schemas.android.com/apk/res/android">
-    <item
-        android:bottom="1dp"
-        android:left="-1dp"
-        android:right="-1dp"
-        android:top="1dp">
-
-        <shape android:shape="rectangle">
-            <solid android:color="?attr/colorSurface"/>
-            <stroke android:width="1dp" android:color="?attr/dividerColor"/>
-        </shape>
-    </item>
-</layer-list>
diff --git a/app/src/main/res/layout/view_background_message.xml b/app/src/main/res/layout/view_background_message.xml
index 12f0108052..51203bf34e 100644
--- a/app/src/main/res/layout/view_background_message.xml
+++ b/app/src/main/res/layout/view_background_message.xml
@@ -1,24 +1,32 @@
 <?xml version="1.0" encoding="utf-8"?>
 <merge xmlns:android="http://schemas.android.com/apk/res/android"
-    xmlns:tools="http://schemas.android.com/tools"
     xmlns:app="http://schemas.android.com/apk/res-auto"
+    xmlns:tools="http://schemas.android.com/tools"
     android:layout_width="match_parent"
     android:layout_height="match_parent"
     android:orientation="vertical"
     tools:parentTag="android.widget.LinearLayout">
 
-    <TextView
-        android:id="@+id/helpText"
-        android:visibility="gone"
+    <com.google.android.material.card.MaterialCardView
+        android:id="@+id/helpTextCard"
+        style="@style/Widget.Material3.CardView.Filled"
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
-        android:lineSpacingMultiplier="1.1"
-        android:textColor="@color/textColorPrimary"
-        android:background="@drawable/help_message_background"
-        android:layout_marginTop="16dp"
-        android:padding="16dp"
-        android:textAlignment="viewStart"
-        android:textSize="?attr/status_text_medium" />
+        android:layout_margin="8dp"
+        android:visibility="gone"
+        app:cardBackgroundColor="?attr/colorSurface">
+
+        <TextView
+            android:id="@+id/helpText"
+            android:layout_width="match_parent"
+            android:layout_height="wrap_content"
+            android:layout_margin="16dp"
+            android:lineSpacingMultiplier="1.1"
+            android:textColor="@color/textColorPrimary"
+            android:textSize="?attr/status_text_medium"
+            tools:text="@string/help_empty_home" />
+
+    </com.google.android.material.card.MaterialCardView>
 
     <LinearLayout
         android:layout_width="match_parent"
@@ -43,8 +51,8 @@
             android:drawablePadding="16dp"
             android:lineSpacingMultiplier="1.1"
             android:paddingLeft="16dp"
-            android:paddingRight="16dp"
             android:paddingTop="16dp"
+            android:paddingRight="16dp"
             android:text="@string/error_network"
             android:textAlignment="center"
             android:textSize="?attr/status_text_medium" />
@@ -54,8 +62,8 @@
             style="@style/TuskyButton.Outlined"
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
-            android:layout_marginBottom="4dp"
             android:layout_marginTop="8dp"
+            android:layout_marginBottom="4dp"
             android:text="@string/action_retry" />
     </LinearLayout>
 </merge>

From 97d64245478baef97cd23fdf4d91aacb20bd24b3 Mon Sep 17 00:00:00 2001
From: Conny Duck <git@connyduck.at>
Date: Sun, 15 Sep 2024 20:02:02 +0200
Subject: [PATCH 05/11] use MaterialDialog in DialogFragments

---
 .../tusky/AccountsInListFragment.kt           | 24 ++++++----
 .../account/list/ListSelectionFragment.kt     |  1 -
 .../compose/dialog/CaptionDialog.kt           | 44 ++++++++-----------
 app/src/main/res/layout/dialog_filter.xml     | 39 +++++++++-------
 .../res/layout/dialog_image_description.xml   | 25 -----------
 .../res/layout/view_background_message.xml    |  2 +
 app/src/main/res/values/styles.xml            |  4 --
 7 files changed, 60 insertions(+), 79 deletions(-)

diff --git a/app/src/main/java/com/keylesspalace/tusky/AccountsInListFragment.kt b/app/src/main/java/com/keylesspalace/tusky/AccountsInListFragment.kt
index 3b5d8518f1..bac98a2281 100644
--- a/app/src/main/java/com/keylesspalace/tusky/AccountsInListFragment.kt
+++ b/app/src/main/java/com/keylesspalace/tusky/AccountsInListFragment.kt
@@ -16,6 +16,7 @@
 
 package com.keylesspalace.tusky
 
+import android.app.Dialog
 import android.content.SharedPreferences
 import android.os.Bundle
 import android.view.LayoutInflater
@@ -29,6 +30,7 @@ import androidx.lifecycle.lifecycleScope
 import androidx.recyclerview.widget.DiffUtil
 import androidx.recyclerview.widget.LinearLayoutManager
 import androidx.recyclerview.widget.ListAdapter
+import com.google.android.material.dialog.MaterialAlertDialogBuilder
 import com.keylesspalace.tusky.databinding.FragmentAccountsInListBinding
 import com.keylesspalace.tusky.databinding.ItemFollowRequestBinding
 import com.keylesspalace.tusky.entity.TimelineAccount
@@ -39,7 +41,6 @@ import com.keylesspalace.tusky.util.hide
 import com.keylesspalace.tusky.util.loadAvatar
 import com.keylesspalace.tusky.util.show
 import com.keylesspalace.tusky.util.unsafeLazy
-import com.keylesspalace.tusky.util.viewBinding
 import com.keylesspalace.tusky.util.visible
 import com.keylesspalace.tusky.viewmodel.AccountsInListViewModel
 import com.keylesspalace.tusky.viewmodel.State
@@ -50,13 +51,13 @@ import kotlinx.coroutines.launch
 private typealias AccountInfo = Pair<TimelineAccount, Boolean>
 
 @AndroidEntryPoint
-class AccountsInListFragment : DialogFragment(R.layout.fragment_accounts_in_list) {
+class AccountsInListFragment : DialogFragment() {
 
     @Inject
     lateinit var preferences: SharedPreferences
 
     private val viewModel: AccountsInListViewModel by viewModels()
-    private val binding by viewBinding(FragmentAccountsInListBinding::bind)
+    private lateinit var binding: FragmentAccountsInListBinding
 
     private lateinit var listId: String
     private lateinit var listName: String
@@ -65,7 +66,6 @@ class AccountsInListFragment : DialogFragment(R.layout.fragment_accounts_in_list
 
     override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)
-        setStyle(STYLE_NORMAL, R.style.TuskyDialogFragmentStyle)
         val args = requireArguments()
         listId = args.getString(LIST_ID_ARG)!!
         listName = args.getString(LIST_NAME_ARG)!!
@@ -73,6 +73,12 @@ class AccountsInListFragment : DialogFragment(R.layout.fragment_accounts_in_list
         viewModel.load(listId)
     }
 
+    override fun onCreateDialog(savedInstanceState: Bundle?): Dialog {
+        return MaterialAlertDialogBuilder(requireContext())
+            .setView(createView())
+            .create()
+    }
+
     override fun onStart() {
         super.onStart()
         dialog?.apply {
@@ -84,17 +90,18 @@ class AccountsInListFragment : DialogFragment(R.layout.fragment_accounts_in_list
         }
     }
 
-    override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
+    private fun createView(): View {
+        binding = FragmentAccountsInListBinding.inflate(layoutInflater)
         val adapter = Adapter()
         val searchAdapter = SearchAdapter()
 
-        binding.accountsRecycler.layoutManager = LinearLayoutManager(view.context)
+        binding.accountsRecycler.layoutManager = LinearLayoutManager(binding.root.context)
         binding.accountsRecycler.adapter = adapter
 
-        binding.accountsSearchRecycler.layoutManager = LinearLayoutManager(view.context)
+        binding.accountsSearchRecycler.layoutManager = LinearLayoutManager(binding.root.context)
         binding.accountsSearchRecycler.adapter = searchAdapter
 
-        viewLifecycleOwner.lifecycleScope.launch {
+        lifecycleScope.launch {
             viewModel.state.collect { state ->
                 adapter.submitList(state.accounts.getOrDefault(emptyList()))
 
@@ -122,6 +129,7 @@ class AccountsInListFragment : DialogFragment(R.layout.fragment_accounts_in_list
                 return true
             }
         })
+        return binding.root
     }
 
     private fun setupSearchView(searchAdapter: SearchAdapter, state: State) {
diff --git a/app/src/main/java/com/keylesspalace/tusky/components/account/list/ListSelectionFragment.kt b/app/src/main/java/com/keylesspalace/tusky/components/account/list/ListSelectionFragment.kt
index 3837714969..bfa15b7377 100644
--- a/app/src/main/java/com/keylesspalace/tusky/components/account/list/ListSelectionFragment.kt
+++ b/app/src/main/java/com/keylesspalace/tusky/components/account/list/ListSelectionFragment.kt
@@ -66,7 +66,6 @@ class ListSelectionFragment : DialogFragment() {
 
     override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)
-        setStyle(STYLE_NORMAL, R.style.TuskyDialogFragmentStyle)
         accountId = requireArguments().getString(ARG_ACCOUNT_ID)
     }
 
diff --git a/app/src/main/java/com/keylesspalace/tusky/components/compose/dialog/CaptionDialog.kt b/app/src/main/java/com/keylesspalace/tusky/components/compose/dialog/CaptionDialog.kt
index 4c96bf3360..43abd26e24 100644
--- a/app/src/main/java/com/keylesspalace/tusky/components/compose/dialog/CaptionDialog.kt
+++ b/app/src/main/java/com/keylesspalace/tusky/components/compose/dialog/CaptionDialog.kt
@@ -15,15 +15,14 @@
 
 package com.keylesspalace.tusky.components.compose.dialog
 
+import android.app.Dialog
 import android.content.Context
 import android.graphics.drawable.Animatable
 import android.graphics.drawable.Drawable
 import android.net.Uri
 import android.os.Bundle
 import android.text.InputFilter
-import android.view.LayoutInflater
 import android.view.View
-import android.view.ViewGroup
 import android.view.WindowManager
 import android.widget.LinearLayout
 import androidx.core.os.bundleOf
@@ -32,11 +31,11 @@ import com.bumptech.glide.Glide
 import com.bumptech.glide.load.resource.bitmap.DownsampleStrategy
 import com.bumptech.glide.request.target.CustomTarget
 import com.bumptech.glide.request.transition.Transition
+import com.google.android.material.dialog.MaterialAlertDialogBuilder
 import com.keylesspalace.tusky.R
 import com.keylesspalace.tusky.databinding.DialogImageDescriptionBinding
 import com.keylesspalace.tusky.util.getParcelableCompat
 import com.keylesspalace.tusky.util.hide
-import com.keylesspalace.tusky.util.viewBinding
 
 // https://github.com/tootsuite/mastodon/blob/c6904c0d3766a2ea8a81ab025c127169ecb51373/app/models/media_attachment.rb#L32
 private const val MEDIA_DESCRIPTION_CHARACTER_LIMIT = 1500
@@ -44,22 +43,23 @@ private const val MEDIA_DESCRIPTION_CHARACTER_LIMIT = 1500
 class CaptionDialog : DialogFragment() {
     private lateinit var listener: Listener
 
-    private val binding by viewBinding(DialogImageDescriptionBinding::bind)
+    private lateinit var binding: DialogImageDescriptionBinding
 
     private var animatable: Animatable? = null
 
-    override fun onCreate(savedInstanceState: Bundle?) {
-        super.onCreate(savedInstanceState)
-        setStyle(STYLE_NORMAL, R.style.TuskyDialogFragmentStyle)
+    override fun onCreateDialog(savedInstanceState: Bundle?): Dialog {
+        val localId = arguments?.getInt(LOCAL_ID_ARG) ?: error("Missing localId")
+        return MaterialAlertDialogBuilder(requireContext())
+            .setView(createView(savedInstanceState))
+            .setPositiveButton(android.R.string.ok) { _, _ ->
+                listener.onUpdateDescription(localId, binding.imageDescriptionText.text.toString())
+            }
+            .setNegativeButton(android.R.string.cancel, null)
+            .create()
     }
 
-    override fun onCreateView(
-        inflater: LayoutInflater,
-        container: ViewGroup?,
-        savedInstanceState: Bundle?
-    ): View = inflater.inflate(R.layout.dialog_image_description, container, false)
-
-    override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
+    private fun createView(savedInstanceState: Bundle?): View {
+        binding = DialogImageDescriptionBinding.inflate(layoutInflater)
         val imageView = binding.imageDescriptionView
         imageView.maxZoom = 6f
 
@@ -74,15 +74,6 @@ class CaptionDialog : DialogFragment() {
             binding.imageDescriptionText.setText(it)
         }
 
-        binding.cancelButton.setOnClickListener {
-            dismiss()
-        }
-        val localId = arguments?.getInt(LOCAL_ID_ARG) ?: error("Missing localId")
-        binding.okButton.setOnClickListener {
-            listener.onUpdateDescription(localId, binding.imageDescriptionText.text.toString())
-            dismiss()
-        }
-
         isCancelable = true
         dialog?.setCanceledOnTouchOutside(false) // Dialog is full screen anyway. But without this, taps in navbar while keyboard is up can dismiss the dialog.
 
@@ -104,15 +95,15 @@ class CaptionDialog : DialogFragment() {
                     if (resource is Animatable) {
                         resource.callback = object : Drawable.Callback {
                             override fun invalidateDrawable(who: Drawable) {
-                                view.invalidate()
+                                imageView.invalidate()
                             }
 
                             override fun scheduleDrawable(who: Drawable, what: Runnable, `when`: Long) {
-                                view.postDelayed(what, `when`)
+                                imageView.postDelayed(what, `when`)
                             }
 
                             override fun unscheduleDrawable(who: Drawable, what: Runnable) {
-                                view.removeCallbacks(what)
+                                imageView.removeCallbacks(what)
                             }
                         }
                         resource.start()
@@ -126,6 +117,7 @@ class CaptionDialog : DialogFragment() {
                     imageView.hide()
                 }
             })
+        return binding.root
     }
 
     override fun onStart() {
diff --git a/app/src/main/res/layout/dialog_filter.xml b/app/src/main/res/layout/dialog_filter.xml
index 376167d9ad..ee91bbb29c 100644
--- a/app/src/main/res/layout/dialog_filter.xml
+++ b/app/src/main/res/layout/dialog_filter.xml
@@ -1,34 +1,43 @@
 <?xml version="1.0" encoding="utf-8"?>
-<androidx.constraintlayout.widget.ConstraintLayout
-    xmlns:android="http://schemas.android.com/apk/res/android"
+<androidx.constraintlayout.widget.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:app="http://schemas.android.com/apk/res-auto"
     android:layout_width="match_parent"
     android:layout_height="match_parent"
-    android:padding="24dp">
+    android:paddingLeft="20dp"
+    android:paddingTop="16dp"
+    android:paddingRight="20dp">
 
-    <EditText
-        android:id="@+id/phraseEditText"
+    <com.google.android.material.textfield.TextInputLayout
+        android:id="@+id/phraseInputLayout"
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
         android:hint="@string/filter_add_description"
-        android:inputType="text"
-        android:importantForAutofill="no"
-        app:layout_constraintTop_toTopOf="parent"
-        />
+        app:layout_constraintTop_toTopOf="parent">
+
+        <com.google.android.material.textfield.TextInputEditText
+            android:id="@+id/phraseEditText"
+            android:layout_width="match_parent"
+            android:layout_height="wrap_content"
+            android:importantForAutofill="no"
+            android:inputType="text" />
+
+    </com.google.android.material.textfield.TextInputLayout>
+
     <CheckBox
         android:id="@+id/phraseWholeWord"
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
+        android:layout_marginTop="16dp"
         android:text="@string/filter_dialog_whole_word"
-        app:layout_constraintTop_toBottomOf="@id/phraseEditText"
         app:layout_constraintLeft_toLeftOf="parent"
-        />
+        app:layout_constraintTop_toBottomOf="@id/phraseInputLayout" />
+
     <TextView
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
         android:lineSpacingMultiplier="1.1"
-        app:layout_constraintTop_toBottomOf="@id/phraseWholeWord"
-        app:layout_constraintLeft_toLeftOf="parent"
         android:text="@string/filter_dialog_whole_word_description"
-        />
-</androidx.constraintlayout.widget.ConstraintLayout>
\ No newline at end of file
+        app:layout_constraintLeft_toLeftOf="parent"
+        app:layout_constraintTop_toBottomOf="@id/phraseWholeWord" />
+
+</androidx.constraintlayout.widget.ConstraintLayout>
diff --git a/app/src/main/res/layout/dialog_image_description.xml b/app/src/main/res/layout/dialog_image_description.xml
index e44b4887ea..75e278f810 100644
--- a/app/src/main/res/layout/dialog_image_description.xml
+++ b/app/src/main/res/layout/dialog_image_description.xml
@@ -1,5 +1,4 @@
 <?xml version="1.0" encoding="utf-8"?>
-
 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:app="http://schemas.android.com/apk/res-auto"
     xmlns:tools="http://schemas.android.com/tools"
@@ -17,7 +16,6 @@
 
     <com.google.android.material.textfield.TextInputLayout
         style="@style/TuskyTextInput"
-
         android:layout_width="match_parent"
         android:layout_height="0dp"
         android:layout_weight="1"
@@ -39,27 +37,4 @@
 
     </com.google.android.material.textfield.TextInputLayout>
 
-    <LinearLayout
-        android:layout_width="match_parent"
-        android:layout_height="wrap_content"
-        android:layout_weight="0"
-        android:orientation="horizontal"
-        android:gravity="end"
-        android:layout_marginStart="?dialogPreferredPadding"
-        android:layout_marginEnd="?dialogPreferredPadding">
-
-        <Button
-            android:id="@+id/cancelButton"
-            style="@style/TuskyButton.TextButton"
-            android:layout_width="wrap_content"
-            android:layout_height="wrap_content"
-            android:text="@android:string/cancel" />
-
-        <Button
-            android:id="@+id/okButton"
-            style="@style/TuskyButton.TextButton"
-            android:layout_width="wrap_content"
-            android:layout_height="wrap_content"
-            android:text="@android:string/ok" />
-    </LinearLayout>
 </LinearLayout>
diff --git a/app/src/main/res/layout/view_background_message.xml b/app/src/main/res/layout/view_background_message.xml
index 51203bf34e..3bd2efba91 100644
--- a/app/src/main/res/layout/view_background_message.xml
+++ b/app/src/main/res/layout/view_background_message.xml
@@ -65,5 +65,7 @@
             android:layout_marginTop="8dp"
             android:layout_marginBottom="4dp"
             android:text="@string/action_retry" />
+
     </LinearLayout>
+
 </merge>
diff --git a/app/src/main/res/values/styles.xml b/app/src/main/res/values/styles.xml
index 828688e95b..f19d9be7d7 100644
--- a/app/src/main/res/values/styles.xml
+++ b/app/src/main/res/values/styles.xml
@@ -164,10 +164,6 @@
         <item name="backgroundTint">@color/colorBackground</item>
     </style>
 
-    <style name="TuskyDialogFragmentStyle" parent="@style/ThemeOverlay.Material3.Dialog">
-        <item name="dialogCornerRadius">8dp</item>
-    </style>
-
     <style name="TuskyTabAppearance" parent="Widget.Material3.TabLayout">
         <item name="tabIndicatorHeight">4dp</item>
     </style>

From 540faa4a3cd24652e653122119d3d35bad9352d5 Mon Sep 17 00:00:00 2001
From: Conny Duck <git@connyduck.at>
Date: Sun, 15 Sep 2024 20:14:11 +0200
Subject: [PATCH 06/11] improve follow hashtag dialog

---
 .../followedtags/FollowedTagsActivity.kt      | 35 ++++++++-----------
 .../main/res/layout/dialog_follow_hashtag.xml | 28 ++++++++++-----
 2 files changed, 34 insertions(+), 29 deletions(-)

diff --git a/app/src/main/java/com/keylesspalace/tusky/components/followedtags/FollowedTagsActivity.kt b/app/src/main/java/com/keylesspalace/tusky/components/followedtags/FollowedTagsActivity.kt
index 6c64048ec0..50ac67fdb2 100644
--- a/app/src/main/java/com/keylesspalace/tusky/components/followedtags/FollowedTagsActivity.kt
+++ b/app/src/main/java/com/keylesspalace/tusky/components/followedtags/FollowedTagsActivity.kt
@@ -21,6 +21,7 @@ import com.keylesspalace.tusky.R
 import com.keylesspalace.tusky.StatusListActivity
 import com.keylesspalace.tusky.components.compose.ComposeAutoCompleteAdapter
 import com.keylesspalace.tusky.databinding.ActivityFollowedTagsBinding
+import com.keylesspalace.tusky.databinding.DialogFollowHashtagBinding
 import com.keylesspalace.tusky.interfaces.HashtagActionListener
 import com.keylesspalace.tusky.network.MastodonApi
 import com.keylesspalace.tusky.util.copyToClipboard
@@ -60,8 +61,7 @@ class FollowedTagsActivity :
         }
 
         binding.fab.setOnClickListener {
-            val dialog: DialogFragment = FollowTagDialog.newInstance()
-            dialog.show(supportFragmentManager, "dialog")
+            showDialog()
         }
 
         setupAdapter().let { adapter ->
@@ -178,37 +178,30 @@ class FollowedTagsActivity :
         )
     }
 
-    companion object {
-        const val TAG = "FollowedTagsActivity"
-    }
-
-    class FollowTagDialog : DialogFragment() {
-        override fun onCreateDialog(savedInstanceState: Bundle?): Dialog {
-            val layout = layoutInflater.inflate(R.layout.dialog_follow_hashtag, null)
-            val autoCompleteTextView = layout.findViewById<AutoCompleteTextView>(R.id.hashtag)!!
-            autoCompleteTextView.setAdapter(
+     fun showDialog(): Dialog {
+            val dialogBinding = DialogFollowHashtagBinding.inflate(layoutInflater)
+            dialogBinding.hashtagAutoCompleteTextView.setAdapter(
                 ComposeAutoCompleteAdapter(
-                    requireActivity() as FollowedTagsActivity,
+                    this,
                     animateAvatar = false,
                     animateEmojis = false,
                     showBotBadge = false
                 )
             )
 
-            return MaterialAlertDialogBuilder(requireActivity())
+            return MaterialAlertDialogBuilder(this)
                 .setTitle(R.string.dialog_follow_hashtag_title)
-                .setView(layout)
+                .setView(dialogBinding.root)
                 .setPositiveButton(android.R.string.ok) { _, _ ->
-                    (requireActivity() as FollowedTagsActivity).follow(
-                        autoCompleteTextView.text.toString().removePrefix("#")
+                    follow(
+                        dialogBinding.hashtagAutoCompleteTextView.text.toString().removePrefix("#")
                     )
                 }
-                .setNegativeButton(android.R.string.cancel) { _: DialogInterface, _: Int -> }
-                .create()
+                .setNegativeButton(android.R.string.cancel, null)
+                .show()
         }
 
-        companion object {
-            fun newInstance(): FollowTagDialog = FollowTagDialog()
-        }
+    companion object {
+        const val TAG = "FollowedTagsActivity"
     }
 }
diff --git a/app/src/main/res/layout/dialog_follow_hashtag.xml b/app/src/main/res/layout/dialog_follow_hashtag.xml
index cdcf3024bf..dca465eaf5 100644
--- a/app/src/main/res/layout/dialog_follow_hashtag.xml
+++ b/app/src/main/res/layout/dialog_follow_hashtag.xml
@@ -1,16 +1,28 @@
 <?xml version="1.0" encoding="utf-8"?>
 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
+    xmlns:app="http://schemas.android.com/apk/res-auto"
     android:layout_width="match_parent"
-    android:layout_height="match_parent"
-    android:paddingStart="?android:attr/listPreferredItemPaddingStart"
-    android:paddingEnd="?android:attr/listPreferredItemPaddingEnd">
+    android:layout_height="wrap_content"
+    android:paddingLeft="20dp"
+    android:paddingTop="16dp"
+    android:paddingRight="20dp">
 
-    <!-- textNoSuggestions is to disable spell check, it will auto-complete -->
-    <AutoCompleteTextView
-        android:id="@+id/hashtag"
+    <com.google.android.material.textfield.TextInputLayout
+        android:id="@+id/hashtagAutoCompleteInputLayout"
+        style="@style/Widget.Material3.TextInputLayout.OutlinedBox.Dense.ExposedDropdownMenu"
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
-        android:inputType="textNoSuggestions"
-        android:hint="@string/dialog_follow_hashtag_hint" />
+        android:hint="@string/dialog_follow_hashtag_hint"
+        app:endIconMode="none">
+
+        <!-- textNoSuggestions is to disable spell check, it will auto-complete -->
+        <com.google.android.material.textfield.MaterialAutoCompleteTextView
+            android:id="@+id/hashtagAutoCompleteTextView"
+            android:layout_width="match_parent"
+            android:layout_height="wrap_content"
+            android:inputType="textNoSuggestions"
+            android:lines="1" />
+
+    </com.google.android.material.textfield.TextInputLayout>
 
 </LinearLayout>

From d033674644fe84ef0767f0c2ee32d313a806de1c Mon Sep 17 00:00:00 2001
From: Conny Duck <git@connyduck.at>
Date: Sun, 15 Sep 2024 20:26:03 +0200
Subject: [PATCH 07/11] override more colors for the black theme

---
 app/src/main/res/values/styles.xml | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/app/src/main/res/values/styles.xml b/app/src/main/res/values/styles.xml
index f19d9be7d7..a3614800cc 100644
--- a/app/src/main/res/values/styles.xml
+++ b/app/src/main/res/values/styles.xml
@@ -123,6 +123,13 @@
         <item name="windowBackgroundColor">@color/black</item>
 
         <item name="colorSurface">@color/tusky_grey_10</item>
+        <item name="colorSurfaceVariant">@color/tusky_grey_10</item>
+
+        <item name="colorSurfaceContainerLowest">@color/tusky_grey_10</item>
+        <item name="colorSurfaceContainerLow">@color/tusky_grey_10</item>
+        <item name="colorSurfaceContainer">@color/tusky_grey_10</item>
+        <item name="colorSurfaceContainerHigh">@color/tusky_grey_10</item>
+        <item name="colorSurfaceContainerHighest">@color/tusky_grey_10</item>
 
         <item name="iconColor">@color/tusky_grey_40</item>
         <item name="colorBackgroundHighlight">@color/tusky_grey_40</item>

From 7c04f31a9898ac19587cb410217abb0c8683a552 Mon Sep 17 00:00:00 2001
From: Conny Duck <git@connyduck.at>
Date: Sun, 15 Sep 2024 20:38:42 +0200
Subject: [PATCH 08/11] override more colors for the black theme

---
 app/src/main/res/values/styles.xml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/app/src/main/res/values/styles.xml b/app/src/main/res/values/styles.xml
index a3614800cc..69f65a9b11 100644
--- a/app/src/main/res/values/styles.xml
+++ b/app/src/main/res/values/styles.xml
@@ -136,6 +136,8 @@
         <item name="colorBackgroundAccent">@color/tusky_grey_20</item>
 
         <item name="dividerColor">@color/tusky_grey_20</item>
+        <item name="colorOutlineVariant">@color/tusky_grey_20</item>
+
     </style>
 
     <style name="TuskyBlackTheme" parent="TuskyBlackThemeBase" />

From 9028b06b966fb3b8f755896fda9354c8acc16f8d Mon Sep 17 00:00:00 2001
From: Conny Duck <git@connyduck.at>
Date: Sun, 15 Sep 2024 20:49:51 +0200
Subject: [PATCH 09/11] improve add hashtag dialog

---
 .../tusky/TabPreferenceActivity.kt            | 17 +++---------
 app/src/main/res/layout/activity_main.xml     |  2 ++
 .../main/res/layout/dialog_add_hashtag.xml    | 27 +++++++++++++++++++
 3 files changed, 33 insertions(+), 13 deletions(-)
 create mode 100644 app/src/main/res/layout/dialog_add_hashtag.xml

diff --git a/app/src/main/java/com/keylesspalace/tusky/TabPreferenceActivity.kt b/app/src/main/java/com/keylesspalace/tusky/TabPreferenceActivity.kt
index 7cd0b8eacd..e7ab6c75c1 100644
--- a/app/src/main/java/com/keylesspalace/tusky/TabPreferenceActivity.kt
+++ b/app/src/main/java/com/keylesspalace/tusky/TabPreferenceActivity.kt
@@ -19,11 +19,8 @@ import android.graphics.Color
 import android.os.Bundle
 import android.view.View
 import android.view.WindowManager
-import android.widget.FrameLayout
 import androidx.activity.OnBackPressedCallback
 import androidx.appcompat.app.AlertDialog
-import androidx.appcompat.widget.AppCompatEditText
-import androidx.core.view.updatePadding
 import androidx.core.widget.doOnTextChanged
 import androidx.lifecycle.lifecycleScope
 import androidx.recyclerview.widget.DividerItemDecoration
@@ -31,7 +28,6 @@ import androidx.recyclerview.widget.ItemTouchHelper
 import androidx.recyclerview.widget.LinearLayoutManager
 import androidx.recyclerview.widget.RecyclerView
 import androidx.transition.TransitionManager
-import at.connyduck.sparkbutton.helpers.Utils
 import com.google.android.material.dialog.MaterialAlertDialogBuilder
 import com.google.android.material.transition.MaterialArcMotion
 import com.google.android.material.transition.MaterialContainerTransform
@@ -41,6 +37,7 @@ import com.keylesspalace.tusky.appstore.EventHub
 import com.keylesspalace.tusky.appstore.MainTabsChangedEvent
 import com.keylesspalace.tusky.components.account.list.ListSelectionFragment
 import com.keylesspalace.tusky.databinding.ActivityTabPreferenceBinding
+import com.keylesspalace.tusky.databinding.DialogAddHashtagBinding
 import com.keylesspalace.tusky.entity.MastoList
 import com.keylesspalace.tusky.network.MastodonApi
 import com.keylesspalace.tusky.util.unsafeLazy
@@ -231,18 +228,12 @@ class TabPreferenceActivity : BaseActivity(), ItemInteractionListener, ListSelec
     }
 
     private fun showAddHashtagDialog(tab: TabData? = null, tabPosition: Int = 0) {
-        val frameLayout = FrameLayout(this)
-        val padding = Utils.dpToPx(this, 8)
-        frameLayout.updatePadding(left = padding, right = padding)
-
-        val editText = AppCompatEditText(this)
-        editText.setHint(R.string.edit_hashtag_hint)
-        editText.setText("")
-        frameLayout.addView(editText)
+        val dialogBinding = DialogAddHashtagBinding.inflate(layoutInflater)
+        val editText = dialogBinding.addHashtagEditText
 
         val dialog = MaterialAlertDialogBuilder(this)
             .setTitle(R.string.add_hashtag_title)
-            .setView(frameLayout)
+            .setView(dialogBinding.root)
             .setNegativeButton(android.R.string.cancel, null)
             .setPositiveButton(R.string.action_save) { _, _ ->
                 val input = editText.text.toString().trim()
diff --git a/app/src/main/res/layout/activity_main.xml b/app/src/main/res/layout/activity_main.xml
index 64efada860..cd54159277 100644
--- a/app/src/main/res/layout/activity_main.xml
+++ b/app/src/main/res/layout/activity_main.xml
@@ -34,6 +34,8 @@
                 android:layout_height="48dp"
                 android:orientation="horizontal"
                 app:contentInsetStart="0dp"
+                android:paddingLeft="0dp"
+                android:paddingRight="0dp"
                 app:contentInsetStartWithNavigation="0dp"
                 app:navigationContentDescription="@string/action_open_drawer">
 
diff --git a/app/src/main/res/layout/dialog_add_hashtag.xml b/app/src/main/res/layout/dialog_add_hashtag.xml
new file mode 100644
index 0000000000..799a1fb26b
--- /dev/null
+++ b/app/src/main/res/layout/dialog_add_hashtag.xml
@@ -0,0 +1,27 @@
+<?xml version="1.0" encoding="utf-8"?>
+<FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
+    xmlns:app="http://schemas.android.com/apk/res-auto"
+    android:layout_width="match_parent"
+    android:layout_height="wrap_content"
+    android:paddingLeft="20dp"
+    android:paddingTop="16dp"
+    android:paddingRight="20dp">
+
+    <com.google.android.material.textfield.TextInputLayout
+        android:id="@+id/addHashtagInputLayout"
+        style="@style/Widget.Material3.TextInputLayout.OutlinedBox.Dense"
+        android:layout_width="match_parent"
+        android:layout_height="wrap_content"
+        android:hint="@string/edit_hashtag_hint"
+        app:endIconMode="none">
+
+        <com.google.android.material.textfield.TextInputEditText
+            android:id="@+id/addHashtagEditText"
+            android:layout_width="match_parent"
+            android:layout_height="wrap_content"
+            android:inputType="textNoSuggestions"
+            android:lines="1" />
+
+    </com.google.android.material.textfield.TextInputLayout>
+
+</FrameLayout>

From 1a13427891870b336901940d53c8a14415a9d74d Mon Sep 17 00:00:00 2001
From: Conny Duck <git@connyduck.at>
Date: Fri, 27 Sep 2024 17:38:48 +0200
Subject: [PATCH 10/11] fix report done screen

---
 .../report/fragments/ReportDoneFragment.kt       | 16 ++++++++--------
 .../res/layout-land/fragment_report_done.xml     |  4 ++--
 2 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/app/src/main/java/com/keylesspalace/tusky/components/report/fragments/ReportDoneFragment.kt b/app/src/main/java/com/keylesspalace/tusky/components/report/fragments/ReportDoneFragment.kt
index 6961caea42..1c72c04312 100644
--- a/app/src/main/java/com/keylesspalace/tusky/components/report/fragments/ReportDoneFragment.kt
+++ b/app/src/main/java/com/keylesspalace/tusky/components/report/fragments/ReportDoneFragment.kt
@@ -49,11 +49,11 @@ class ReportDoneFragment : Fragment(R.layout.fragment_report_done) {
             viewModel.muteState.collect {
                 if (it == null) return@collect
                 if (it !is Loading) {
-                    binding.buttonMute.show()
-                    binding.progressMute.show()
+                    binding.buttonMute.visibility = View.VISIBLE
+                    binding.progressMute.visibility = View.GONE
                 } else {
-                    binding.buttonMute.hide()
-                    binding.progressMute.hide()
+                    binding.buttonMute.visibility = View.INVISIBLE
+                    binding.progressMute.visibility = View.VISIBLE
                 }
 
                 binding.buttonMute.setText(
@@ -69,11 +69,11 @@ class ReportDoneFragment : Fragment(R.layout.fragment_report_done) {
             viewModel.blockState.collect {
                 if (it == null) return@collect
                 if (it !is Loading) {
-                    binding.buttonBlock.show()
-                    binding.progressBlock.show()
+                    binding.buttonBlock.visibility = View.VISIBLE
+                    binding.progressBlock.visibility = View.GONE
                 } else {
-                    binding.buttonBlock.hide()
-                    binding.progressBlock.hide()
+                    binding.buttonBlock.visibility = View.INVISIBLE
+                    binding.progressBlock.visibility = View.VISIBLE
                 }
                 binding.buttonBlock.setText(
                     when (it.data) {
diff --git a/app/src/main/res/layout-land/fragment_report_done.xml b/app/src/main/res/layout-land/fragment_report_done.xml
index 567449b8eb..63174148dd 100644
--- a/app/src/main/res/layout-land/fragment_report_done.xml
+++ b/app/src/main/res/layout-land/fragment_report_done.xml
@@ -59,7 +59,7 @@
         app:layout_constraintTop_toBottomOf="@id/textReported"
         app:layout_constraintVertical_chainStyle="packed" />
 
-    <com.google.android.material.progressindicator.LinearProgressIndicator
+    <com.google.android.material.progressindicator.CircularProgressIndicator
         android:id="@+id/progressMute"
         style="@style/Widget.Material3.CircularProgressIndicator.Small"
         android:layout_width="wrap_content"
@@ -83,7 +83,7 @@
         app:layout_constraintTop_toBottomOf="@id/buttonMute"
         app:layout_constraintVertical_chainStyle="packed" />
 
-    <com.google.android.material.progressindicator.LinearProgressIndicator
+    <com.google.android.material.progressindicator.CircularProgressIndicator
         android:id="@+id/progressBlock"
         style="@style/Widget.Material3.CircularProgressIndicator.Small"
         android:layout_width="wrap_content"

From fbd1d06701b2e9056fc70b80a51013ce4e45c6ce Mon Sep 17 00:00:00 2001
From: Conny Duck <git@connyduck.at>
Date: Fri, 27 Sep 2024 18:01:59 +0200
Subject: [PATCH 11/11] remove unused imports

---
 .../tusky/components/report/fragments/ReportDoneFragment.kt     | 2 --
 1 file changed, 2 deletions(-)

diff --git a/app/src/main/java/com/keylesspalace/tusky/components/report/fragments/ReportDoneFragment.kt b/app/src/main/java/com/keylesspalace/tusky/components/report/fragments/ReportDoneFragment.kt
index 1c72c04312..ba76973c26 100644
--- a/app/src/main/java/com/keylesspalace/tusky/components/report/fragments/ReportDoneFragment.kt
+++ b/app/src/main/java/com/keylesspalace/tusky/components/report/fragments/ReportDoneFragment.kt
@@ -25,8 +25,6 @@ import com.keylesspalace.tusky.components.report.ReportViewModel
 import com.keylesspalace.tusky.components.report.Screen
 import com.keylesspalace.tusky.databinding.FragmentReportDoneBinding
 import com.keylesspalace.tusky.util.Loading
-import com.keylesspalace.tusky.util.hide
-import com.keylesspalace.tusky.util.show
 import com.keylesspalace.tusky.util.viewBinding
 import dagger.hilt.android.AndroidEntryPoint
 import kotlinx.coroutines.launch