Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warning regarding the order of mixed nested declaration #474

Open
MoritzLost opened this issue Jul 16, 2024 · 3 comments · May be fixed by #477
Open

Deprecation warning regarding the order of mixed nested declaration #474

MoritzLost opened this issue Jul 16, 2024 · 3 comments · May be fixed by #477

Comments

@MoritzLost
Copy link

SASS is introducing a breaking change regarding the output order of nested SCSS rules: https://sass-lang.com/documentation/breaking-changes/mixed-decls/

To help prepare for this, SASS is outputting some deprecation warnings starting with 1.77.7. I'm getting multiple warnings from rfs related to this issue. The affected areas will likely need to change the order of the declarations to get rid of those warnings and prepare for the breaking change, to ensure the variables will still have the correct order (and thereby, precedence).

@XhmikosR
Copy link
Member

XhmikosR commented Sep 2, 2024

@julien-deramond is this correct or all of the deprecation warnings on bootstrap main branch are coming for there?

If we have warnings coming from rfs, we should fix them here and update the included version in Bootstrap.

@julien-deramond
Copy link
Member

Bootstrap main branch is fixed via twbs/bootstrap#40623 (and will be available with v5.3.4).
I don't know well this repository, maybe there are also specific fixes to do here.
When do we see these deprecation warnings in this repository? Running which commands?

@XhmikosR
Copy link
Member

XhmikosR commented Sep 3, 2024

In theory updating sass in this repo to the latest version and running all tests should reveal any warnings.

For example I see this here https://github.com/twbs/examples/actions/runs/10684628167/job/29615519708?pr=496

    ┌──> node_modules/bootstrap/scss/_type.scss
38  │       font-family: $display-font-family;
    │       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ declaration
    ╵
    ┌──> node_modules/bootstrap/scss/vendor/_rfs.scss
136 │ ┌     @media (#{$rfs-mq-property-width}: #{$rfs-mq-value}) {
137 │ │       @content;
138 │ │     }
    │ └─── nested rule
    ╵
    node_modules/bootstrap/scss/_type.scss 38:5  @import

which points to rfs

@julien-deramond julien-deramond linked a pull request Sep 3, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants