Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace STAUTOPLAY with a simple flag #19

Open
twopointzero opened this issue Mar 11, 2020 · 0 comments
Open

Replace STAUTOPLAY with a simple flag #19

twopointzero opened this issue Mar 11, 2020 · 0 comments
Labels
chore Changes unrelated to enhancements or bug fixes

Comments

@twopointzero
Copy link
Owner

Can you write a one-sentence description of your request?
Replace STAUTOPLAY with a simple flag.

What is the current behavior?
STAUTOPLAY is a structure of many members, each representing various parts of instruments no longer supported by the software. The code (that matters) always sets all of its values true or false, usually via a loop, and then the structure gets passed around and processed by indexing into its content over and over.

What is the expected behavior?
Especially with the removal of viewer support, this structure and all code processing it can be replaced with the management of a simple boolean and, as it just so happens, the code that cares was already having to manage another autoplay-related boolean for that anyway, so those can almost surely be merged.

What is the motivation / use case for changing the behavior?
Code complexity, maintainability, the usual. :)

@twopointzero twopointzero added the chore Changes unrelated to enhancements or bug fixes label Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes unrelated to enhancements or bug fixes
Projects
None yet
Development

No branches or pull requests

1 participant