Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the sixth Balloon_Breaking texture to show the balloon pop #40

Open
twopointzero opened this issue May 31, 2020 · 2 comments
Open
Labels
bug Something isn't working

Comments

@twopointzero
Copy link
Owner

Can you write a one-sentence description of your request?
Six Balloon_Breaking textures are loaded in TextureLoader but only five are ever selected and rendered.

What is the current behavior?
I have not double-checked the behaviour since spotting this in the code, but I suspect the balloon never appears to pop and rather just disappears.

What is the expected behavior?
The balloon should pop instead of disappear. Check other forks as they may have addressed this.

What is the motivation / use case for changing the behavior?
Not popping would be odd.

@twopointzero twopointzero added the bug Something isn't working label May 31, 2020
@gczark
Copy link

gczark commented Aug 22, 2020

This could be skin related.
If the skin is supposed to have 5 sprites and added 1 later on; without delving in the SkinConfig.ini, the added sprite is not acknowledged.

Game_Chara_Motion_Normal=13,13,12,11,10,9,8,7,6,5,4,3,2,1,0,0,13,13,12,11,10,9,8,7,6,5,4,3,2,1,0,0 is included in the config file, I think this has effect on display order of sprites.

@twopointzero
Copy link
Owner Author

twopointzero commented Aug 22, 2020

It's actually simpler than that, somewhat thankfully :). The code literally loads a hard coded set of six textures and then iterates over that set with a hard coded assumption that there are only five.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants