Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p.44: Confusion about setting env vars in Windows #32

Open
jadient opened this issue Feb 17, 2014 · 1 comment
Open

p.44: Confusion about setting env vars in Windows #32

jadient opened this issue Feb 17, 2014 · 1 comment

Comments

@jadient
Copy link

jadient commented Feb 17, 2014

The instructions for setting environment variables in Windows are confusing.

  1. The text says that Windows is tricky, but at the end, eventually goes on to recommend the same approach that's mentioned above for Linux and Mac (i.e., add to the end of the activate script). I recommend dropping the "is trickier" because I don't see that (if this was referring to the need to restart the command interpreter, you'd need to do the same thing if modifying .bashrc etc.).

  2. The text says there's an issue with setx but then goes on to use it anyway. Perhaps you meant to use set in the example?

  3. Using setx for secret information makes me nervous because it places the information in the registry (it looks like that's the same for the PowerShell examples). I'm wondering if it might be better to omit all mention of how to store secret information persistently. What do you think?

@pydanny
Copy link
Member

pydanny commented Apr 10, 2015

@jadient In regards to item 3, would you suggest just using secrets.json for storing of unversioned keys?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants