Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Come up with long-term approach to exposing copy(...) method in binding classes #1629

Open
krzema12 opened this issue Aug 26, 2024 · 1 comment
Assignees
Milestone

Comments

@krzema12
Copy link
Member

Kotlin 2.0.20 compiler started producing warnings if the primary constructor of a data class is private: https://kotlinlang.org/docs/whatsnew2020.html#data-class-copy-function-to-have-the-same-visibility-as-constructor

As a short-term approach, we just suppress the warning, and the customers get a warning on the call site which is independent of this library. However, we'd like to keep exposing this method, so let's discuss what options we have to choose once starting using Kotlin 2.1.0.

Discussion: https://kotlinlang.slack.com/archives/C02UUATR7RC/p1724584851609139

@krzema12
Copy link
Member Author

Let's see if someone has some interesting take on this: https://kotlinlang.slack.com/archives/C8C4JTXR7/p1729233924861659

@krzema12 krzema12 added this to the v4.x.x milestone Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants