-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core feature request] Model matrix
context
#368
Comments
I can't run the project for now because of a timeout
I've started designing this but I have an outage that prevents me to go further for now |
Drafting something on my own: https://github.com/krzema12/github-workflows-kt/tree/368-add-matrix-support |
@jmfayard do you plan to work on this? I'm asking because you're still assigned here. |
You closed his PR and deleted his branch in January, saying you are drafting it yourself, so, ... :-D |
Ok, so I'm deprioritizing it for v1, to be able to release a "good enough" stable version faster. |
When adressing this, please also consider being able to configure non-string matrix values. |
just curious if there have been any updates regarding the priority of this? |
@tangdev-w3 it's on hold until client-side binding generation (reducing operational effort of maintaining this library) is done. It's also pretty tricky to implement elegantly and type-safely, which is another reason I just haven't done it yet. Open for suggestions, PoCs and any other contributions. |
@tangdev-w3 could you share your exact use case? It will be helpful when deciding on the scope of support to be added. |
Use [github-workflows-kt](https://github.com/typesafegithub/github-workflows-kt) to implement the workflow in Kotlin, increasing maintainability and readability. Note: proper, type-safe matrix strategy support is yet to be implemented, it's tracked in typesafegithub/github-workflows-kt#368. # Testing done 1. Compared what's logged in the "Store benchmark result" step as "Data", and there are no differences. * version from `main` branch: https://github.com/krzema12/snakeyaml-engine-kmp/actions/runs/10187305280/job/28181268567 * version from this branch: https://github.com/krzema12/snakeyaml-engine-kmp/actions/runs/10244555647/job/28338076917?pr=221 2. Compared with https://www.yamldiff.com/. Most important differences: * the new version has a consistency check which is required to ensure that the YAML reflects what's described in Kotlin * the new version doesn't have the reports preprocessing step implemented directly, and instead delegates it to the Kotlin script itself * instead of using step outputs or env vars (so effectively to not repeat ourselves with the file paths), I just used Kotlin's constants * github-workflows-kt proactively adds step IDs to be able to refer to them whenever needed ![SemanticDiff](https://github.com/user-attachments/assets/d77eb0fc-9129-4121-92a7-e3bc822a1318)
What feature do you need?
https://docs.github.com/en/actions/learn-github-actions/contexts#matrix-context
Also look at related feature requests: #287 and #297.
Do you have an example usage?
Is there a workaround for not having this feature? If yes, please describe it.
The text was updated successfully, but these errors were encountered: