Skip to content

Consider enabling createDefaultProgram #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JoshuaKGoldberg opened this issue Oct 9, 2020 · 3 comments
Closed

Consider enabling createDefaultProgram #739

JoshuaKGoldberg opened this issue Oct 9, 2020 · 3 comments
Labels
area: lint configurations Improving settings placed into lint configurations outside of rules. type: enhancement New feature or request

Comments

@JoshuaKGoldberg
Copy link
Member

🚀 Feature Request

Forking conversation from #738 (comment):

Also, I have seen this fix on many other issues and wonder why it doesn't get placed on default if it fixes many issues.

In .eslintrc.js inside "parserOptions" placing

'createDefaultProgram': true

Seems to fix a lot of eslint issues with my IDE.

Existing Behavior

createDefaultProgram is not mentioned anywhere in this repository.

Change Proposal

Should it be included in the default output configuration? If so, should it be always on, opt-in with a flag, or opt-out with a flag?

Investigation required!

@JoshuaKGoldberg JoshuaKGoldberg added area: lint configurations Improving settings placed into lint configurations outside of rules. status: needs investigation Let's dig deeper into this before drawing conclusions. type: enhancement New feature or request labels Oct 9, 2020
@adidahiya
Copy link

I don't think this option should be enabled by default. From the README:

Using this option will incur significant performance costs. This option is primarily included for backwards-compatibility.

This performance hit was true in practice in the Blueprint repo, where we initially enabled it and then disabled the option. So I don't think tslint-to-eslint-config should encourage its usage.

@JoshuaKGoldberg
Copy link
Member Author

That's a very good reason not to. Thanks!

@JoshuaKGoldberg JoshuaKGoldberg removed the status: needs investigation Let's dig deeper into this before drawing conclusions. label Oct 12, 2020
@idemax
Copy link

idemax commented Apr 6, 2023

any update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: lint configurations Improving settings placed into lint configurations outside of rules. type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants