Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert single value attributes parsing #27

Closed
Krolken opened this issue Feb 19, 2021 · 1 comment
Closed

Revert single value attributes parsing #27

Krolken opened this issue Feb 19, 2021 · 1 comment
Assignees
Labels
wontfix This will not be worked on

Comments

@Krolken
Copy link
Contributor

Krolken commented Feb 19, 2021

The XADRParser is now returning the value if an attribute is just a single value and a list of values if there is more values.
This made it annoying building a more general way reading alot of values.

It would be better if the function returned a list in either case. If it is a single value you will need to access the first element in the list instead.

@Krolken Krolken self-assigned this Feb 19, 2021
@Krolken
Copy link
Contributor Author

Krolken commented Feb 19, 2021

Actually this was harder than I thought.
Since we have APDU parsing dependant of the Parser in some spots it either made the code very unclean or broke apdu-parsing to get the correct handling.

It is a bit dependant on #26 since when the parser is no longer handling apdu-parsing we can cut alot of functionality and all the extra fluff that was added so that the parser could handle sequences of dlms-data to and just make a simple and pure parser for that.

@Krolken Krolken added the wontfix This will not be worked on label Feb 19, 2021
@Krolken Krolken closed this as completed Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant