From 71c0b3208def173422407214eb14a26cbe2b388a Mon Sep 17 00:00:00 2001 From: Tim Nyborg Date: Mon, 18 Jul 2022 13:37:36 +0100 Subject: [PATCH 1/2] correct typing on get* functions The typing of getLineWidth, getRadius, etc. doesn't reflect that they're passed isSelected and mode --- modules/layers/src/layers/editable-geojson-layer.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/modules/layers/src/layers/editable-geojson-layer.ts b/modules/layers/src/layers/editable-geojson-layer.ts index e37c4bf8f..56997cb13 100644 --- a/modules/layers/src/layers/editable-geojson-layer.ts +++ b/modules/layers/src/layers/editable-geojson-layer.ts @@ -133,12 +133,12 @@ export interface EditableGeojsonLayerProps extends EditableLayerProps { getLineColor?: RGBAColor | ((feature, isSelected, mode) => RGBAColor); getFillColor?: RGBAColor | ((feature, isSelected, mode) => RGBAColor); - getRadius?: number | ((f) => number); - getLineWidth?: number | ((f) => number); + getRadius?: number | ((feature, isSelected, mode) => number); + getLineWidth?: number | ((feature, isSelected, mode) => number); getTentativeLineColor?: RGBAColor | ((feature, isSelected, mode) => RGBAColor); getTentativeFillColor?: RGBAColor | ((feature, isSelected, mode) => RGBAColor); - getTentativeLineWidth?: number | ((f) => number); + getTentativeLineWidth?: number | ((feature, isSelected, mode) => number); editHandleType?: string; From ae186e42cdefe2af2d5653a3c477f315c6a59277 Mon Sep 17 00:00:00 2001 From: Tim Nyborg Date: Mon, 9 Jan 2023 13:51:27 +0000 Subject: [PATCH 2/2] revert getTentativeLineWidth typing --- modules/layers/src/layers/editable-geojson-layer.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/layers/src/layers/editable-geojson-layer.ts b/modules/layers/src/layers/editable-geojson-layer.ts index 5541fe4d1..8a4118017 100644 --- a/modules/layers/src/layers/editable-geojson-layer.ts +++ b/modules/layers/src/layers/editable-geojson-layer.ts @@ -138,7 +138,7 @@ export type EditableGeojsonLayerProps = EditableLayerProps & getTentativeLineColor?: Color | ((feature, isSelected, mode) => Color); getTentativeFillColor?: Color | ((feature, isSelected, mode) => Color); - getTentativeLineWidth?: number | ((feature, isSelected, mode) => number); + getTentativeLineWidth?: number | ((f) => number); editHandleType?: string;