Skip to content

Commit 4903129

Browse files
authored
chore(tests): clean up "passed" logging in integration tests (#355)
## Why? Bazel already reports pass/fail outcome on test cases - logging that a test case passed is redundant ## What? Remove logging at the end of tests that just log "passed" ## Test Plan - CI run
1 parent 502e0cf commit 4903129

5 files changed

Lines changed: 0 additions & 42 deletions

File tree

test/integration/extension/counter/suite.go

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,6 @@ func (s *CounterContractSuite) TestCounter_Next() {
7171
seq3, err := s.counter.Next(ctx, domain)
7272
require.NoError(t, err)
7373
assert.Equal(t, seq2+1, seq3, "sequence should continue incrementing")
74-
75-
s.log.Logf("Next test passed: %d → %d → %d", seq1, seq2, seq3)
7674
}
7775

7876
// TestCounter_MultipleDomains tests independent counters
@@ -99,9 +97,6 @@ func (s *CounterContractSuite) TestCounter_MultipleDomains() {
9997
// Each domain should increment independently
10098
assert.Equal(t, seq1a+1, seq1b, "domain1 should increment")
10199
assert.Equal(t, seq2a+1, seq2b, "domain2 should increment")
102-
103-
s.log.Logf("Multiple domains test passed: domain1=%d→%d, domain2=%d→%d",
104-
seq1a, seq1b, seq2a, seq2b)
105100
}
106101

107102
// TestCounter_Concurrency tests concurrent access to the same counter
@@ -141,7 +136,4 @@ func (s *CounterContractSuite) TestCounter_Concurrency() {
141136
assert.Equal(t, sequences[i-1]+1, sequences[i],
142137
"sequences should be contiguous at index %d: got %d and %d", i, sequences[i-1], sequences[i])
143138
}
144-
145-
s.log.Logf("Concurrency test passed: %d goroutines generated %d contiguous sequences (%d-%d)",
146-
numGoroutines, len(sequences), sequences[0], sequences[len(sequences)-1])
147139
}

test/integration/stovepipe/extension/storage/suite.go

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,6 @@ func (s *QueueStoreContractSuite) TestQueueStore_Create() {
7070
LatestRequestID: "",
7171
Version: 1,
7272
}, got)
73-
74-
s.log.Logf("Create passed: created queue %s", name)
7573
}
7674

7775
// TestQueueStore_CreateWithFields verifies caller-supplied initial field values are persisted.
@@ -90,8 +88,6 @@ func (s *QueueStoreContractSuite) TestQueueStore_CreateWithFields() {
9088
got, err := s.queueStore.Get(s.ctx, name)
9189
require.NoError(t, err)
9290
assert.Equal(t, toCreate, got)
93-
94-
s.log.Logf("CreateWithFields passed: persisted fields for queue %s", name)
9591
}
9692

9793
// TestQueueStore_CreateAlreadyExists verifies a duplicate Create returns ErrAlreadyExists.
@@ -113,8 +109,6 @@ func (s *QueueStoreContractSuite) TestQueueStore_CreateAlreadyExists() {
113109
got, err := s.queueStore.Get(s.ctx, name)
114110
require.NoError(t, err)
115111
assert.Equal(t, first, got)
116-
117-
s.log.Logf("CreateAlreadyExists passed: queue %s", name)
118112
}
119113

120114
// TestQueueStore_GetNotFound verifies Get returns ErrNotFound for a missing queue.
@@ -123,8 +117,6 @@ func (s *QueueStoreContractSuite) TestQueueStore_GetNotFound() {
123117

124118
_, err := s.queueStore.Get(s.ctx, "contract/does-not-exist")
125119
assert.True(t, storage.IsNotFound(err))
126-
127-
s.log.Logf("GetNotFound passed")
128120
}
129121

130122
// TestQueueStore_UpdateCAS verifies a conditional update persists all mutable fields and rejects stale versions.
@@ -150,8 +142,6 @@ func (s *QueueStoreContractSuite) TestQueueStore_UpdateCAS() {
150142

151143
err = s.queueStore.Update(s.ctx, updated, 1, 2)
152144
assert.ErrorIs(t, err, storage.ErrVersionMismatch)
153-
154-
s.log.Logf("UpdateCAS passed: queue %s", name)
155145
}
156146

157147
// TestQueueStore_UpdateNotFoundIsVersionMismatch verifies Update on a missing row returns ErrVersionMismatch.
@@ -160,8 +150,6 @@ func (s *QueueStoreContractSuite) TestQueueStore_UpdateNotFoundIsVersionMismatch
160150

161151
err := s.queueStore.Update(s.ctx, entity.Queue{Name: "contract/missing"}, 1, 2)
162152
assert.ErrorIs(t, err, storage.ErrVersionMismatch)
163-
164-
s.log.Logf("UpdateNotFoundIsVersionMismatch passed")
165153
}
166154

167155
// TestQueueStore_UpdateSequentialCAS verifies successive conditional updates advance version monotonically.
@@ -182,8 +170,6 @@ func (s *QueueStoreContractSuite) TestQueueStore_UpdateSequentialCAS() {
182170
assert.Equal(t, "request/contract/sequential-cas/10", got.LatestRequestID)
183171
assert.Equal(t, int32(1), got.InFlightCount)
184172
assert.Equal(t, int32(3), got.Version)
185-
186-
s.log.Logf("UpdateSequentialCAS passed: queue %s", name)
187173
}
188174

189175
// BuildStoreContractSuite defines contract tests for storage.BuildStore.
@@ -392,6 +378,4 @@ func (s *QueueStoreContractSuite) TestQueueStore_QueueIsolation() {
392378
gotB, err := s.queueStore.Get(s.ctx, nameB)
393379
require.NoError(t, err)
394380
assert.Equal(t, baseline, gotB)
395-
396-
s.log.Logf("QueueIsolation passed: queues %s and %s", nameA, nameB)
397381
}

test/integration/submitqueue/extension/storage/suite.go

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,6 @@ func (s *StorageContractSuite) TestStorage_CreateAndGet() {
8484
assert.Equal(t, request.Change.URIs, retrieved.Change.URIs)
8585
assert.Equal(t, request.LandStrategy, retrieved.LandStrategy)
8686
assert.Equal(t, request.Version, retrieved.Version)
87-
88-
s.log.Logf("CreateAndGet test passed: created and retrieved request %s", request.ID)
8987
}
9088

9189
// TestStorage_CreateAndGet_StackedPRs tests creating and retrieving a request with stacked PRs
@@ -124,8 +122,6 @@ func (s *StorageContractSuite) TestStorage_CreateAndGet_StackedPRs() {
124122
assert.Equal(t, stackedURIs, retrieved.Change.URIs, "stacked PR URIs should be preserved exactly")
125123
assert.Equal(t, request.ID, retrieved.ID)
126124
assert.Equal(t, request.LandStrategy, retrieved.LandStrategy)
127-
128-
s.log.Logf("CreateAndGet_StackedPRs test passed: %d stacked URIs", len(stackedURIs))
129125
}
130126

131127
// TestStorage_UpdateState tests updating request state
@@ -154,8 +150,6 @@ func (s *StorageContractSuite) TestStorage_UpdateState() {
154150
require.NoError(t, err)
155151
assert.Equal(t, entity.RequestStateProcessing, retrieved.State)
156152
assert.Equal(t, int32(2), retrieved.Version, "version should increment after update")
157-
158-
s.log.Logf("UpdateState test passed: updated request %s to state %s", request.ID, retrieved.State)
159153
}
160154

161155
// TestStorage_OptimisticLocking tests version-based optimistic locking
@@ -189,8 +183,6 @@ func (s *StorageContractSuite) TestStorage_OptimisticLocking() {
189183
require.NoError(t, err)
190184
assert.Equal(t, entity.RequestStateProcessing, retrieved.State, "stale update should not modify state")
191185
assert.Equal(t, int32(2), retrieved.Version)
192-
193-
s.log.Logf("Optimistic locking test passed: prevented stale update for request %s", request.ID)
194186
}
195187

196188
// TestStorage_NotFound tests getting a non-existent request
@@ -202,8 +194,6 @@ func (s *StorageContractSuite) TestStorage_NotFound() {
202194
_, err := s.storage.GetRequestStore().Get(ctx, "test/nonexistent")
203195
assert.Error(t, err, "getting non-existent request should return error")
204196
assert.ErrorIs(t, err, storage.ErrNotFound, "should return ErrNotFound")
205-
206-
s.log.Logf("NotFound test passed: correctly returned ErrNotFound")
207197
}
208198

209199
// TestStorage_CreateDuplicate tests creating a request with duplicate ID
@@ -227,8 +217,6 @@ func (s *StorageContractSuite) TestStorage_CreateDuplicate() {
227217
err = s.storage.GetRequestStore().Create(ctx, request)
228218
assert.Error(t, err, "creating duplicate request should return error")
229219
assert.ErrorIs(t, err, storage.ErrAlreadyExists, "should return ErrAlreadyExists")
230-
231-
s.log.Logf("CreateDuplicate test passed: prevented duplicate creation")
232220
}
233221

234222
// changeURI is a representative change URI reused across change-store contract tests.

test/integration/submitqueue/gateway/suite_test.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -140,8 +140,6 @@ func (s *GatewayIntegrationSuite) TestPingAPI() {
140140
assert.Equal(t, "gateway", resp.ServiceName)
141141
assert.NotEmpty(t, resp.Message)
142142
assert.NotZero(t, resp.Timestamp)
143-
144-
s.log.Logf("Gateway Ping test passed: %s", resp.Message)
145143
}
146144

147145
// TestLandAPI tests the Gateway Land API with queue publishing
@@ -166,8 +164,6 @@ func (s *GatewayIntegrationSuite) TestLandAPI() {
166164
err = s.queueDB.QueryRow("SELECT COUNT(*) FROM queue_messages WHERE id = ?", resp.Sqid).Scan(&msgCount)
167165
require.NoError(t, err, "failed to query queue messages")
168166
assert.Equal(t, 1, msgCount, "should have 1 message in queue")
169-
170-
s.log.Logf("Land API test passed: request stored and message published")
171167
}
172168

173169
// TestListAPI verifies the queue projection is exposed in deterministic receipt order.

test/integration/submitqueue/orchestrator/suite_test.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,4 @@ func (s *OrchestratorIntegrationSuite) TestPingAPI() {
114114
assert.Equal(t, "orchestrator", resp.ServiceName)
115115
assert.NotEmpty(t, resp.Message)
116116
assert.NotZero(t, resp.Timestamp)
117-
118-
s.log.Logf("Orchestrator Ping test passed: %s", resp.Message)
119117
}

0 commit comments

Comments
 (0)