|
| 1 | +// Copyright (c) 2025 Uber Technologies, Inc. |
| 2 | +// |
| 3 | +// Licensed under the Apache License, Version 2.0 (the "License"); |
| 4 | +// you may not use this file except in compliance with the License. |
| 5 | +// You may obtain a copy of the License at |
| 6 | +// |
| 7 | +// http://www.apache.org/licenses/LICENSE-2.0 |
| 8 | +// |
| 9 | +// Unless required by applicable law or agreed to in writing, software |
| 10 | +// distributed under the License is distributed on an "AS IS" BASIS, |
| 11 | +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 12 | +// See the License for the specific language governing permissions and |
| 13 | +// limitations under the License. |
| 14 | + |
| 15 | +package mapper |
| 16 | + |
| 17 | +import ( |
| 18 | + "testing" |
| 19 | + |
| 20 | + "github.com/stretchr/testify/assert" |
| 21 | + "github.com/stretchr/testify/require" |
| 22 | + changepb "github.com/uber/submitqueue/api/base/change/protopb" |
| 23 | + mergestrategypb "github.com/uber/submitqueue/api/base/mergestrategy/protopb" |
| 24 | + pb "github.com/uber/submitqueue/api/submitqueue/gateway/protopb" |
| 25 | + "github.com/uber/submitqueue/platform/base/change" |
| 26 | + "github.com/uber/submitqueue/platform/base/mergestrategy" |
| 27 | + "github.com/uber/submitqueue/submitqueue/entity" |
| 28 | +) |
| 29 | + |
| 30 | +func TestProtoToLandRequest(t *testing.T) { |
| 31 | + const uri = "github://github.example.com/uber/test-repo/pull/1/c3a4d5e6f7890123456789abcdef0123456789ab" |
| 32 | + |
| 33 | + tests := []struct { |
| 34 | + name string |
| 35 | + req *pb.LandRequest |
| 36 | + expected entity.LandRequest |
| 37 | + expectedErr error |
| 38 | + }{ |
| 39 | + { |
| 40 | + name: "maps all fields and leaves ID empty", |
| 41 | + req: &pb.LandRequest{ |
| 42 | + Queue: "test-queue", |
| 43 | + Change: &changepb.Change{Uris: []string{uri}}, |
| 44 | + Strategy: mergestrategypb.Strategy_SQUASH_REBASE, |
| 45 | + }, |
| 46 | + // ID is not assigned by the mapper — the controller mints it. |
| 47 | + expected: entity.LandRequest{ |
| 48 | + Queue: "test-queue", |
| 49 | + Change: change.Change{URIs: []string{uri}}, |
| 50 | + LandStrategy: mergestrategy.MergeStrategySquashRebase, |
| 51 | + }, |
| 52 | + }, |
| 53 | + { |
| 54 | + name: "nil change yields empty URIs without erroring", |
| 55 | + req: &pb.LandRequest{Queue: "test-queue", Change: nil}, |
| 56 | + // The mapper does not validate; it leaves URIs empty for the controller to reject. |
| 57 | + expected: entity.LandRequest{ |
| 58 | + Queue: "test-queue", |
| 59 | + LandStrategy: mergestrategy.MergeStrategyRebase, |
| 60 | + }, |
| 61 | + }, |
| 62 | + { |
| 63 | + name: "unknown strategy errors", |
| 64 | + req: &pb.LandRequest{ |
| 65 | + Queue: "test-queue", |
| 66 | + Change: &changepb.Change{Uris: []string{uri}}, |
| 67 | + Strategy: mergestrategypb.Strategy(9999), |
| 68 | + }, |
| 69 | + expectedErr: errUnknownStrategy, |
| 70 | + }, |
| 71 | + } |
| 72 | + |
| 73 | + for _, tt := range tests { |
| 74 | + t.Run(tt.name, func(t *testing.T) { |
| 75 | + got, err := ProtoToLandRequest(tt.req) |
| 76 | + if tt.expectedErr != nil { |
| 77 | + require.ErrorIs(t, err, tt.expectedErr) |
| 78 | + return |
| 79 | + } |
| 80 | + require.NoError(t, err) |
| 81 | + assert.Equal(t, tt.expected, got) |
| 82 | + }) |
| 83 | + } |
| 84 | +} |
| 85 | + |
| 86 | +func TestResolveMergeStrategy(t *testing.T) { |
| 87 | + tests := []struct { |
| 88 | + name string |
| 89 | + in mergestrategypb.Strategy |
| 90 | + want mergestrategy.MergeStrategy |
| 91 | + errMsg string |
| 92 | + }{ |
| 93 | + {name: "default", in: mergestrategypb.Strategy_DEFAULT, want: mergestrategy.MergeStrategyRebase}, |
| 94 | + {name: "rebase", in: mergestrategypb.Strategy_REBASE, want: mergestrategy.MergeStrategyRebase}, |
| 95 | + {name: "squash_rebase", in: mergestrategypb.Strategy_SQUASH_REBASE, want: mergestrategy.MergeStrategySquashRebase}, |
| 96 | + {name: "merge", in: mergestrategypb.Strategy_MERGE, want: mergestrategy.MergeStrategyMerge}, |
| 97 | + {name: "unknown", in: mergestrategypb.Strategy(9999), errMsg: "unknown land strategy in proto message"}, |
| 98 | + } |
| 99 | + |
| 100 | + for _, tt := range tests { |
| 101 | + t.Run(tt.name, func(t *testing.T) { |
| 102 | + got, err := resolveMergeStrategy(tt.in) |
| 103 | + if tt.errMsg != "" { |
| 104 | + assert.ErrorContains(t, err, tt.errMsg) |
| 105 | + return |
| 106 | + } |
| 107 | + assert.NoError(t, err) |
| 108 | + assert.Equal(t, tt.want, got) |
| 109 | + }) |
| 110 | + } |
| 111 | +} |
0 commit comments